Bug 165481 - Remove old Wasm object model
Summary: Remove old Wasm object model
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks: 165482
  Show dependency tree / graph
 
Reported: 2016-12-06 11:19 PST by Saam Barati
Modified: 2016-12-06 16:28 PST (History)
12 users (show)

See Also:

Attachments
patch (49.81 KB, patch)
2016-12-06 12:45 PST, Saam Barati 		keith_miller: review+
Details | Formatted Diff | Diff
patch for landing (49.83 KB, patch)
2016-12-06 14:46 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-12-06 11:19:29 PST 
It makes the current code quite confusing to read.
Comment 1 Saam Barati 2016-12-06 12:45:46 PST 
Created attachment 296309 [details]
patch
Comment 2 Keith Miller 2016-12-06 12:47:31 PST 
Comment on attachment 296309 [details]
patch

r=me.
Comment 3 WebKit Commit Bot 2016-12-06 12:48:18 PST 
Attachment 296309 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ChangeLog:7:  Line contains tab character.  [whitespace/tab] [5]
ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1296:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Mark Lam 2016-12-06 12:48:45 PST 
Comment on attachment 296309 [details]
patch

r=me too.
Comment 5 Saam Barati 2016-12-06 14:46:13 PST 
Created attachment 296325 [details]
patch for landing
Comment 6 WebKit Commit Bot 2016-12-06 14:48:40 PST 
Attachment 296325 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:1296:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2016-12-06 16:28:26 PST 
Comment on attachment 296325 [details]
patch for landing

Clearing flags on attachment: 296325

Committed r209433: <http://trac.webkit.org/changeset/209433>
Comment 8 WebKit Commit Bot 2016-12-06 16:28:30 PST 
All reviewed patches have been landed.  Closing bug.