Bug 165470 - Add HTML interactive form validation blacklist for some WebKit-specific sites
Summary: Add HTML interactive form validation blacklist for some WebKit-specific sites
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-06 09:23 PST by Chris Dumez
Modified: 2016-12-14 19:49 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.25 KB, patch)
2016-12-06 09:26 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-12-06 09:23:37 PST 
Add HTML interactive form validation blacklist for some WebKit-specific sites expecting our old behavior, until they get a chance to be updated.
Comment 1 Chris Dumez 2016-12-06 09:23:59 PST 
<rdar://problem/29509424>
Comment 2 Chris Dumez 2016-12-06 09:26:57 PST 
Created attachment 296295 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-12-06 11:54:12 PST 
Comment on attachment 296295 [details]
Patch

This should check m_page->settings().needsSiteSpecificQuirks() like our other quirks.
Comment 4 Chris Dumez 2016-12-06 13:09:53 PST 
(In reply to comment #3)
> Comment on attachment 296295 [details]
> Patch
> 
> This should check m_page->settings().needsSiteSpecificQuirks() like our
> other quirks.

This setting is off by default in MobileSafari :/
Comment 5 Chris Dumez 2016-12-06 13:40:29 PST 
Comment on attachment 296295 [details]
Patch

Clearing flags on attachment: 296295

Committed r209415: <http://trac.webkit.org/changeset/209415>
Comment 6 Chris Dumez 2016-12-06 13:40:34 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Chris Dumez 2016-12-14 16:48:32 PST 
Reverted r209415 for reason:

This workaround is no longer needed now that <rdar://problem/29518605> has been fixed

Committed r209844: <http://trac.webkit.org/changeset/209844>