Bug 165454 - Move RenderElement::rendererForRootBackground to RenderView.
Summary: Move RenderElement::rendererForRootBackground to RenderView.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-05 20:11 PST by zalan
Modified: 2016-12-06 17:16 PST (History)
5 users (show)

See Also:


Attachments
Patch (12.22 KB, patch)
2016-12-05 20:27 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (12.25 KB, patch)
2016-12-05 21:07 PST, zalan
no flags Details | Formatted Diff | Diff
Patch (12.34 KB, patch)
2016-12-06 15:27 PST, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-12-05 20:11:35 PST
And remove the limitation that this function can only be called on isDocumentElementRenderer() objects.
Comment 1 zalan 2016-12-05 20:27:15 PST
Created attachment 296255 [details]
Patch
Comment 2 zalan 2016-12-05 21:07:29 PST
Created attachment 296261 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-12-06 15:15:10 PST
Comment on attachment 296261 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296261&action=review

> Source/WebCore/rendering/RenderView.cpp:523
> +    if (!is<HTMLHtmlElement>(documentRenderer.element()))
> +        return &documentRenderer;
> +
> +    if (documentRenderer.hasBackground())
> +        return &documentRenderer;

Swap these around and maybe add a comment saying that this is an HTML-specific behavior.
Comment 4 zalan 2016-12-06 15:27:46 PST
Created attachment 296334 [details]
Patch
Comment 5 WebKit Commit Bot 2016-12-06 17:16:09 PST
Comment on attachment 296334 [details]
Patch

Clearing flags on attachment: 296334

Committed r209438: <http://trac.webkit.org/changeset/209438>
Comment 6 WebKit Commit Bot 2016-12-06 17:16:13 PST
All reviewed patches have been landed.  Closing bug.