RESOLVED FIXED 165452
Enable visual viewports by default on Mac, and iOS Wk2
https://bugs.webkit.org/show_bug.cgi?id=165452
Summary Enable visual viewports by default on Mac, and iOS Wk2
Simon Fraser (smfr)
Reported 2016-12-05 19:24:30 PST
Enable visual viewports by default on Mac, and iOS Wk2
Attachments
Patch (3.32 KB, patch)
2016-12-05 19:25 PST, Simon Fraser (smfr)
no flags
Archive of layout-test-results from ews103 for mac-yosemite (1.08 MB, application/zip)
2016-12-05 20:15 PST, Build Bot
no flags
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.68 MB, application/zip)
2016-12-05 20:18 PST, Build Bot
no flags
Archive of layout-test-results from ews116 for mac-yosemite (1.72 MB, application/zip)
2016-12-05 20:33 PST, Build Bot
no flags
Archive of layout-test-results from ews126 for ios-simulator-wk2 (12.38 MB, application/zip)
2016-12-05 20:52 PST, Build Bot
no flags
Patch (17.33 KB, patch)
2016-12-05 22:52 PST, Simon Fraser (smfr)
no flags
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.29 MB, application/zip)
2016-12-05 23:27 PST, Build Bot
no flags
Archive of layout-test-results from ews122 for ios-simulator-wk2 (7.01 MB, application/zip)
2016-12-06 00:24 PST, Build Bot
no flags
Patch (41.76 KB, patch)
2016-12-06 08:47 PST, Simon Fraser (smfr)
zalan: review+
buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.18 MB, application/zip)
2016-12-06 09:33 PST, Build Bot
no flags
Archive of layout-test-results from ews121 for ios-simulator-wk2 (9.50 MB, application/zip)
2016-12-06 10:03 PST, Build Bot
no flags
Simon Fraser (smfr)
Comment 1 2016-12-05 19:25:19 PST
Simon Fraser (smfr)
Comment 2 2016-12-05 19:32:59 PST
Build Bot
Comment 3 2016-12-05 20:15:04 PST
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2631288 New failing tests: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html compositing/layer-creation/fixed-position-out-of-view-scaled.html compositing/repaint/scroll-fixed-layer-no-content.html fast/zooming/client-rect-in-fixed-zoomed.html compositing/repaint/scroll-fixed-layer-out-of-view.html animations/trigger-container-scroll-boundaries.html compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html animations/trigger-container-scroll-simple.html animations/trigger-container-scroll-empty.html
Build Bot
Comment 4 2016-12-05 20:15:07 PST
Created attachment 296252 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-12-05 20:18:22 PST
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2631332 Number of test failures exceeded the failure limit.
Build Bot
Comment 6 2016-12-05 20:18:26 PST
Created attachment 296253 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-12-05 20:33:19 PST
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2631365 New failing tests: compositing/geometry/fixed-position-composited-page-scale-smaller-than-viewport.html compositing/layer-creation/fixed-position-out-of-view-scaled.html compositing/repaint/scroll-fixed-layer-no-content.html fast/zooming/client-rect-in-fixed-zoomed.html compositing/repaint/scroll-fixed-layer-out-of-view.html animations/trigger-container-scroll-boundaries.html compositing/layer-creation/fixed-position-out-of-view-scaled-scroll.html animations/trigger-container-scroll-simple.html animations/trigger-container-scroll-empty.html
Build Bot
Comment 8 2016-12-05 20:33:23 PST
Created attachment 296257 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 9 2016-12-05 20:52:23 PST
Comment on attachment 296248 [details] Patch Attachment 296248 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2631407 New failing tests: compositing/geometry/fixed-in-composited.html compositing/geometry/limit-layer-bounds-fixed.html compositing/geometry/limit-layer-bounds-fixed-positioned.html fast/scrolling/ios/remove-scrolling-role.html compositing/repaint/scroll-fixed-layer-no-content.html compositing/repaint/scroll-fixed-layer-out-of-view.html scrollingcoordinator/ios/non-stable-viewport-scroll.html fast/overflow/position-fixed-transform-clipping.html compositing/layer-creation/fixed-position-under-transform.html animations/trigger-container-scroll-simple.html scrollingcoordinator/ios/ui-scrolling-tree.html
Build Bot
Comment 10 2016-12-05 20:52:26 PST
Created attachment 296260 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 11 2016-12-05 22:52:43 PST
Build Bot
Comment 12 2016-12-05 23:27:46 PST
Comment on attachment 296276 [details] Patch Attachment 296276 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2632151 Number of test failures exceeded the failure limit.
Build Bot
Comment 13 2016-12-05 23:27:49 PST
Created attachment 296278 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 14 2016-12-06 00:24:22 PST
Comment on attachment 296276 [details] Patch Attachment 296276 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2632254 New failing tests: compositing/geometry/limit-layer-bounds-fixed.html compositing/geometry/fixed-in-composited.html compositing/layer-creation/no-compositing-for-sticky.html compositing/layer-creation/fixed-position-under-transform.html compositing/geometry/limit-layer-bounds-fixed-positioned.html
Build Bot
Comment 15 2016-12-06 00:24:25 PST
Created attachment 296281 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 16 2016-12-06 08:47:31 PST
alan baradlay
Comment 17 2016-12-06 09:08:48 PST
Comment on attachment 296290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=296290&action=review > Source/WebCore/page/FrameView.cpp:1862 > + if (m_layoutPhase == InViewSizeAdjust) > + return; I don't think it makes sense to update the layout viewport while in layout at all. (not just when InViewSizeAdjust) (though I assume we normally don't call back on it during layout -assertion maybe?)
Build Bot
Comment 18 2016-12-06 09:33:31 PST
Comment on attachment 296290 [details] Patch Attachment 296290 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2634379 New failing tests: tiled-drawing/scrolling/frames/coordinated-frame-gain-scrolling-ancestor.html tiled-drawing/scrolling/frames/coordinated-frame-lose-scrolling-ancestor.html tiled-drawing/scrolling/fixed/four-bars-zoomed.html
Build Bot
Comment 19 2016-12-06 09:33:35 PST
Created attachment 296296 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 20 2016-12-06 10:03:44 PST
Comment on attachment 296290 [details] Patch Attachment 296290 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2634473 New failing tests: compositing/geometry/limit-layer-bounds-fixed.html compositing/geometry/fixed-in-composited.html compositing/layer-creation/no-compositing-for-sticky.html compositing/layer-creation/fixed-position-under-transform.html compositing/geometry/limit-layer-bounds-fixed-positioned.html
Build Bot
Comment 21 2016-12-06 10:03:47 PST
Created attachment 296297 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Simon Fraser (smfr)
Comment 22 2016-12-06 12:01:38 PST
Note You need to log in before you can comment on or make changes to this bug.