Bug 165451 - Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code Style Guidelines
Summary: Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code St...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-05 18:42 PST by Daniel Bates
Modified: 2016-12-06 09:47 PST (History)
4 users (show)

See Also:


Attachments
Patch (6.46 KB, patch)
2016-12-05 18:49 PST, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-12-05 18:42:54 PST
The functions Document::shouldEnforceHTTP0_9Sandbox() and ResourceResponseBase::isHttpVersion0_9() do not conform the naming conventions in the WebKit Code Style Guidelines. We should rename them so that they conform to the guidelines and are more consistent with the rest of the codebase.
Comment 1 Daniel Bates 2016-12-05 18:49:26 PST
Created attachment 296244 [details]
Patch

I chose to standardize on the substring "HTTP09" in the names of these functions. Would "HTTPVersion09" be more understandable? I am open to naming suggestions.
Comment 2 Daniel Bates 2016-12-06 09:47:15 PST
Comment on attachment 296244 [details]
Patch

Clearing flags on attachment: 296244

Committed r209403: <http://trac.webkit.org/changeset/209403>
Comment 3 Daniel Bates 2016-12-06 09:47:19 PST
All reviewed patches have been landed.  Closing bug.