WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165451
Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code Style Guidelines
https://bugs.webkit.org/show_bug.cgi?id=165451
Summary
Cleanup: Rename some HTTP 0.9-specific functions to conform to WebKit Code St...
Daniel Bates
Reported
2016-12-05 18:42:54 PST
The functions Document::shouldEnforceHTTP0_9Sandbox() and ResourceResponseBase::isHttpVersion0_9() do not conform the naming conventions in the WebKit Code Style Guidelines. We should rename them so that they conform to the guidelines and are more consistent with the rest of the codebase.
Attachments
Patch
(6.46 KB, patch)
2016-12-05 18:49 PST
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2016-12-05 18:49:26 PST
Created
attachment 296244
[details]
Patch I chose to standardize on the substring "HTTP09" in the names of these functions. Would "HTTPVersion09" be more understandable? I am open to naming suggestions.
Daniel Bates
Comment 2
2016-12-06 09:47:15 PST
Comment on
attachment 296244
[details]
Patch Clearing flags on attachment: 296244 Committed
r209403
: <
http://trac.webkit.org/changeset/209403
>
Daniel Bates
Comment 3
2016-12-06 09:47:19 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug