Bug 165448 - [Modern Media Controls] Controls bar in fullscreen cannot be dragged
Summary: [Modern Media Controls] Controls bar in fullscreen cannot be dragged
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-05 18:33 PST by Antoine Quint
Modified: 2016-12-05 22:56 PST (History)
3 users (show)

See Also:


Attachments
Patch (11.62 KB, patch)
2016-12-05 18:35 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.15 MB, application/zip)
2016-12-05 19:12 PST, Build Bot
no flags Details
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (1.46 MB, application/zip)
2016-12-05 19:21 PST, Build Bot
no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (1.80 MB, application/zip)
2016-12-05 19:27 PST, Build Bot
no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (9.71 MB, application/zip)
2016-12-05 20:31 PST, Build Bot
no flags Details
Patch for landing (18.48 KB, patch)
2016-12-05 22:19 PST, Antoine Quint
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-12-05 18:33:41 PST
[Modern Media Controls] Controls bar in fullscreen cannot be dragged
Comment 1 Antoine Quint 2016-12-05 18:35:53 PST
Created attachment 296242 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-12-05 18:38:01 PST
Comment on attachment 296242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296242&action=review

> LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:31
> +            // mediaControls.querySelector(".controls-bar").dispatchEvent(new MouseEvent("mousedown", { clientX: 174, clientY: 508 }));
> +            // mediaControls.dispatchEvent(new MouseEvent("mousemove", { clientX: 124, clientY: 408 }));
> +            // mediaControls.dispatchEvent(new MouseEvent("mouseup"));

Oooh shit.

> LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:52
> +setTimeout(finishJSTest, 3000);

Whoa.
Comment 3 Build Bot 2016-12-05 19:12:16 PST
Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2630956

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
Comment 4 Build Bot 2016-12-05 19:12:18 PST
Created attachment 296246 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-12-05 19:21:06 PST
Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2631002

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
Comment 6 Build Bot 2016-12-05 19:21:08 PST
Created attachment 296247 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-12-05 19:26:59 PST
Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2631013

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
Comment 8 Build Bot 2016-12-05 19:27:02 PST
Created attachment 296249 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Build Bot 2016-12-05 20:31:00 PST
Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2631328

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html
Comment 10 Build Bot 2016-12-05 20:31:03 PST
Created attachment 296256 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 11 Antoine Quint 2016-12-05 22:19:48 PST
Created attachment 296272 [details]
Patch for landing
Comment 12 WebKit Commit Bot 2016-12-05 22:56:10 PST
Comment on attachment 296272 [details]
Patch for landing

Clearing flags on attachment: 296272

Committed r209388: <http://trac.webkit.org/changeset/209388>
Comment 13 WebKit Commit Bot 2016-12-05 22:56:14 PST
All reviewed patches have been landed.  Closing bug.