Bug 165448 – [Modern Media Controls] Controls bar in fullscreen cannot be dragged

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Antoine Quint]

[Modern Media Controls] Controls bar in fullscreen cannot be dragged

[Antoine Quint]

Created attachment 296242 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 296242 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296242&action=review

> LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:31
> +            // mediaControls.querySelector(".controls-bar").dispatchEvent(new MouseEvent("mousedown", { clientX: 174, clientY: 508 }));
> +            // mediaControls.dispatchEvent(new MouseEvent("mousemove", { clientX: 124, clientY: 408 }));
> +            // mediaControls.dispatchEvent(new MouseEvent("mouseup"));

Oooh shit.

> LayoutTests/media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html:52
> +setTimeout(finishJSTest, 3000);

Whoa.

[Build Bot]

Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2630956

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html

[Build Bot]

Created attachment 296246 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2631002

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html

[Build Bot]

Created attachment 296247 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2631013

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html

[Build Bot]

Created attachment 296249 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296242 [details]
Patch

Attachment 296242 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2631328

New failing tests:
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-controls-bar-styles.html
media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-containers-styles.html

[Build Bot]

Created attachment 296256 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Antoine Quint]

Created attachment 296272 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 296272 [details]
Patch for landing

Clearing flags on attachment: 296272

Committed r209388: <http://trac.webkit.org/changeset/209388>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.