Bug 165425 - Exit pointer lock when page goes into page cache.
Summary: Exit pointer lock when page goes into page cache.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
: 164956 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-12-05 15:16 PST by Jeremy Jones
Modified: 2017-02-23 13:24 PST (History)
9 users (show)

See Also:

Attachments
Patch (7.64 KB, patch)
2016-12-05 21:16 PST, Jeremy Jones 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (9.02 KB, patch)
2016-12-07 20:34 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2016-12-05 15:16:47 PST 
Exit pointer lock when page goes into page cache.
Comment 1 Jeremy Jones 2016-12-05 15:17:18 PST 
rdar://problem/29430834
Comment 2 Jeremy Jones 2016-12-05 21:16:43 PST 
Created attachment 296263 [details]
Patch
Comment 3 Jeremy Jones 2016-12-05 21:48:33 PST 
*** Bug 164956 has been marked as a duplicate of this bug. ***
Comment 4 Jer Noble 2016-12-06 13:10:33 PST 
Comment on attachment 296263 [details]
Patch

r=me, with nit: this patch doesn't have any expected results; you should generate them with run-webkit-tests --reset-results before committing.
Comment 5 Jeremy Jones 2016-12-07 20:34:39 PST 
Created attachment 296476 [details]
Patch for landing.
Comment 6 WebKit Commit Bot 2016-12-07 22:20:25 PST 
Comment on attachment 296476 [details]
Patch for landing.

Clearing flags on attachment: 296476

Committed r209525: <http://trac.webkit.org/changeset/209525>
Comment 7 Alexey Proskuryakov 2017-02-02 16:47:06 PST 
Should this bug be closed now?
Comment 8 Chris Dumez 2017-02-22 21:56:32 PST 
Comment on attachment 296476 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=296476&action=review

> Source/WebCore/ChangeLog:9
> +        Test: pointer-lock/lock-lost-on-navigation.html

This test does not cover the code change since it does not enable PageCache. Not that PageCache is disabled by default in layout tests unless explicitly enabled via:
testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);
Comment 9 Chris Dumez 2017-02-22 21:56:50 PST 
(In reply to comment #8)
> Comment on attachment 296476 [details]
> Patch for landing.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296476&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Test: pointer-lock/lock-lost-on-navigation.html
> 
> This test does not cover the code change since it does not enable PageCache.
> Not that PageCache is disabled by default in layout tests unless explicitly
> enabled via:
> testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);

s/Not/Note
Comment 10 Chris Dumez 2017-02-22 22:02:27 PST 
Comment on attachment 296476 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=296476&action=review

> Source/WebCore/testing/Internals.idl:487
> +    [Conditional=POINTER_LOCK] boolean pageHasPendingPointerLock();

nit: This would have probably been nicer as an enum attribute instead of 2 separate operations, e.g.:
enum PointerLockState { "inactive", "pending", "active");
readonly PointerLockState pagePointerLockState;
Comment 11 Chris Dumez 2017-02-23 13:24:28 PST 
Test needs fixing.