Bug 165425 – Exit pointer lock when page goes into page cache.

• Status: REOPENED
• Component: New Bugs

[Jeremy Jones]

Exit pointer lock when page goes into page cache.

[Jeremy Jones]

rdar://problem/29430834

[Jeremy Jones]

Created attachment 296263 [details]
Patch

[Jeremy Jones]

*** Bug 164956 has been marked as a duplicate of this bug. ***

[Jer Noble]

Comment on attachment 296263 [details]
Patch

r=me, with nit: this patch doesn't have any expected results; you should generate them with run-webkit-tests --reset-results before committing.

[Jeremy Jones]

Created attachment 296476 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 296476 [details]
Patch for landing.

Clearing flags on attachment: 296476

Committed r209525: <http://trac.webkit.org/changeset/209525>

[Alexey Proskuryakov]

Should this bug be closed now?

[Chris Dumez]

Comment on attachment 296476 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=296476&action=review

> Source/WebCore/ChangeLog:9
> +        Test: pointer-lock/lock-lost-on-navigation.html

This test does not cover the code change since it does not enable PageCache. Not that PageCache is disabled by default in layout tests unless explicitly enabled via:
testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);

[Chris Dumez]

(In reply to comment #8)
> Comment on attachment 296476 [details]
> Patch for landing.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296476&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        Test: pointer-lock/lock-lost-on-navigation.html
> 
> This test does not cover the code change since it does not enable PageCache.
> Not that PageCache is disabled by default in layout tests unless explicitly
> enabled via:
> testRunner.overridePreference("WebKitUsesPageCachePreferenceKey", 1);

s/Not/Note

[Chris Dumez]

Comment on attachment 296476 [details]
Patch for landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=296476&action=review

> Source/WebCore/testing/Internals.idl:487
> +    [Conditional=POINTER_LOCK] boolean pageHasPendingPointerLock();

nit: This would have probably been nicer as an enum attribute instead of 2 separate operations, e.g.:
enum PointerLockState { "inactive", "pending", "active");
readonly PointerLockState pagePointerLockState;

[Chris Dumez]

Test needs fixing.