Bug 165423 - pointer lock should exit when a js alert is shown
Summary: pointer lock should exit when a js alert is shown
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-05 15:08 PST by Jeremy Jones
Modified: 2017-11-02 11:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.18 KB, patch)
2016-12-05 15:09 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (4.17 KB, patch)
2016-12-05 21:24 PST, Jeremy Jones 		jer.noble: review+
Details | Formatted Diff | Diff
Patch for landing. (5.85 KB, patch)
2016-12-07 19:19 PST, Jeremy Jones 		jeremyj-wk: commit-queue-
Details | Formatted Diff | Diff
Patch for landing. (5.84 KB, patch)
2016-12-07 22:04 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2016-12-05 15:08:31 PST 
pointer lock should exit when a js alert is shown
Comment 1 Jeremy Jones 2016-12-05 15:09:51 PST 
Created attachment 296197 [details]
Patch
Comment 2 Jeremy Jones 2016-12-05 15:10:40 PST 
rdar://problem/29430803
Comment 3 Jon Lee 2016-12-05 15:15:40 PST 
Comment on attachment 296197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296197&action=review

> Source/WebCore/page/DOMWindow.cpp:1145
> +    page->pointerLockController().requestPointerUnlock();

Should this exist in confirm() and prompt() dialogs as well?
Comment 4 Jeremy Jones 2016-12-05 21:24:58 PST 
Created attachment 296265 [details]
Patch
Comment 5 Jeremy Jones 2016-12-05 21:25:53 PST 
(In reply to comment #3)
> Comment on attachment 296197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296197&action=review
> 
> > Source/WebCore/page/DOMWindow.cpp:1145
> > +    page->pointerLockController().requestPointerUnlock();
> 
> Should this exist in confirm() and prompt() dialogs as well?

Added implementation for confirm() and prompt().
Also fixed build error.
Comment 6 Jer Noble 2016-12-06 16:43:44 PST 
Comment on attachment 296265 [details]
Patch

r=me with nit: please generate expected.txt results before landing.
Comment 7 Jeremy Jones 2016-12-07 19:19:08 PST 
Created attachment 296461 [details]
Patch for landing.
Comment 8 Jeremy Jones 2016-12-07 22:04:55 PST 
Created attachment 296485 [details]
Patch for landing.
Comment 9 WebKit Commit Bot 2016-12-07 22:15:46 PST 
Comment on attachment 296485 [details]
Patch for landing.

Rejecting attachment 296485 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 296485, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ubmit
    return self.open(self.click(*args, **kwds))
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://webkit-queues.webkit.org/results/2649403
Comment 10 WebKit Commit Bot 2016-12-08 12:01:29 PST 
Comment on attachment 296485 [details]
Patch for landing.

Clearing flags on attachment: 296485

Committed r209555: <http://trac.webkit.org/changeset/209555>