Bug 165423 – pointer lock should exit when a js alert is shown

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Jones]

pointer lock should exit when a js alert is shown

[Jeremy Jones]

Created attachment 296197 [details]
Patch

[Jeremy Jones]

rdar://problem/29430803

[Jon Lee]

Comment on attachment 296197 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296197&action=review

> Source/WebCore/page/DOMWindow.cpp:1145
> +    page->pointerLockController().requestPointerUnlock();

Should this exist in confirm() and prompt() dialogs as well?

[Jeremy Jones]

Created attachment 296265 [details]
Patch

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 296197 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296197&action=review
> 
> > Source/WebCore/page/DOMWindow.cpp:1145
> > +    page->pointerLockController().requestPointerUnlock();
> 
> Should this exist in confirm() and prompt() dialogs as well?

Added implementation for confirm() and prompt().
Also fixed build error.

[Jer Noble]

Comment on attachment 296265 [details]
Patch

r=me with nit: please generate expected.txt results before landing.

[Jeremy Jones]

Created attachment 296461 [details]
Patch for landing.

[Jeremy Jones]

Created attachment 296485 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 296485 [details]
Patch for landing.

Rejecting attachment 296485 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 296485, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ubmit
    return self.open(self.click(*args, **kwds))
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 203, in open
    return self._mech_open(url, data, timeout=timeout)
  File "/Volumes/Data/EWS/WebKit/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_mechanize.py", line 255, in _mech_open
    raise response
webkitpy.thirdparty.autoinstalled.mechanize._response.httperror_seek_wrapper: HTTP Error 500: Internal Server Error

Full output: http://webkit-queues.webkit.org/results/2649403

[WebKit Commit Bot]

Comment on attachment 296485 [details]
Patch for landing.

Clearing flags on attachment: 296485

Committed r209555: <http://trac.webkit.org/changeset/209555>