Bug 165422 – Moved start and end column linking into helper functions

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Geoffrey Garen]

Moved start and end column linking into helper functions

[Geoffrey Garen]

Created attachment 296198 [details]
Patch

[Geoffrey Garen]

Committed r209361: <http://trac.webkit.org/changeset/209361>

[Mark Lam]

Comment on attachment 296198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296198&action=review

> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:93
> +    unsigned linkedEndColumn(unsigned startColumn) const { return m_lineCount ? m_unlinkedBodyEndColumn : startColumn + m_unlinkedBodyEndColumn; }

This is wrong.  The original code adds 1 to m_unlinkedBodyEndColumn if m_lineCount is non-zero.  You didn't add 1 here.

[Ryan Haddad]

(In reply to comment #2)
> Committed r209361: <http://trac.webkit.org/changeset/209361>

LayoutTest js/dom/script-start-end-locations.html is failing after this change: https://build.webkit.org/results/Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r209361%20(11509)/results.html

[Saam Barati]

(In reply to comment #4)
> (In reply to comment #2)
> > Committed r209361: <http://trac.webkit.org/changeset/209361>
> 
> LayoutTest js/dom/script-start-end-locations.html is failing after this
> change:
> https://build.webkit.org/results/
> Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r209361%20(11509)/results.html

Has this been fixed?

[Geoffrey Garen]

I'll check today.

[Ryan Haddad]

(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #2)
> > > Committed r209361: <http://trac.webkit.org/changeset/209361>
> > 
> > LayoutTest js/dom/script-start-end-locations.html is failing after this
> > change:
> > https://build.webkit.org/results/
> > Apple%20El%20Capitan%20Release%20WK2%20(Tests)/r209361%20(11509)/results.html
> 
> Has this been fixed?

The test is passing now according to the flakiness dashboard:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=js%2Fdom%2Fscript-start-end-locations.html

[Geoffrey Garen]

Nice!