Bug 165416 – One esc to exit fullscreen and pointer lock

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jeremy Jones]

one esc to exit fullscreen and pointer lock

[Jeremy Jones]

rdar://problem/29430711

[Jeremy Jones]

Created attachment 296196 [details]
Patch

[Jon Lee]

Comment on attachment 296196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296196&action=review

> Source/WebCore/ChangeLog:3
> +        one esc to exit fullscreen and pointer lock

One

> Source/WebCore/page/EventHandler.cpp:-3068
> -        return true;

Please explain in the change log why this is removed.

[Jeremy Jones]

Created attachment 296269 [details]
Patch

[Jeremy Jones]

(In reply to comment #3)
> Comment on attachment 296196 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296196&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        one esc to exit fullscreen and pointer lock
> 
> One

dOne

> 
> > Source/WebCore/page/EventHandler.cpp:-3068
> > -        return true;
> 
> Please explain in the change log why this is removed.

Done.

[Jer Noble]

Comment on attachment 296269 [details]
Patch

r=me with nit, please generate expected.txt results before landing.

[Jeremy Jones]

Created attachment 296429 [details]
Patch

[Jeremy Jones]

Comment on attachment 296429 [details]
Patch

This is missing most of the patch.

[Jeremy Jones]

Created attachment 296430 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 296430 [details]
Patch

Clearing flags on attachment: 296430

Committed r209504: <http://trac.webkit.org/changeset/209504>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.