Bug 165416 - One esc to exit fullscreen and pointer lock
Summary: One esc to exit fullscreen and pointer lock
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-05 14:34 PST by Jeremy Jones
Modified: 2016-12-07 17:19 PST (History)
5 users (show)

See Also:

Attachments
Patch (3.80 KB, patch)
2016-12-05 14:58 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (4.12 KB, patch)
2016-12-05 21:43 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (4.98 KB, patch)
2016-12-07 15:51 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (13.13 KB, patch)
2016-12-07 15:54 PST, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2016-12-05 14:34:32 PST 
one esc to exit fullscreen and pointer lock
Comment 1 Jeremy Jones 2016-12-05 14:36:07 PST 
rdar://problem/29430711
Comment 2 Jeremy Jones 2016-12-05 14:58:44 PST 
Created attachment 296196 [details]
Patch
Comment 3 Jon Lee 2016-12-05 15:13:31 PST 
Comment on attachment 296196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296196&action=review

> Source/WebCore/ChangeLog:3
> +        one esc to exit fullscreen and pointer lock

One

> Source/WebCore/page/EventHandler.cpp:-3068
> -        return true;

Please explain in the change log why this is removed.
Comment 4 Jeremy Jones 2016-12-05 21:43:09 PST 
Created attachment 296269 [details]
Patch
Comment 5 Jeremy Jones 2016-12-06 09:43:26 PST 
(In reply to comment #3)
> Comment on attachment 296196 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=296196&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        one esc to exit fullscreen and pointer lock
> 
> One

dOne

> 
> > Source/WebCore/page/EventHandler.cpp:-3068
> > -        return true;
> 
> Please explain in the change log why this is removed.

Done.
Comment 6 Jer Noble 2016-12-06 16:43:13 PST 
Comment on attachment 296269 [details]
Patch

r=me with nit, please generate expected.txt results before landing.
Comment 7 Jeremy Jones 2016-12-07 15:51:18 PST 
Created attachment 296429 [details]
Patch
Comment 8 Jeremy Jones 2016-12-07 15:52:01 PST 
Comment on attachment 296429 [details]
Patch

This is missing most of the patch.
Comment 9 Jeremy Jones 2016-12-07 15:54:05 PST 
Created attachment 296430 [details]
Patch
Comment 10 WebKit Commit Bot 2016-12-07 17:19:31 PST 
Comment on attachment 296430 [details]
Patch

Clearing flags on attachment: 296430

Committed r209504: <http://trac.webkit.org/changeset/209504>
Comment 11 WebKit Commit Bot 2016-12-07 17:19:35 PST 
All reviewed patches have been landed.  Closing bug.