Bug 165413 - Web Inspector: remove ASSERT from InspectorDebuggerAgent::derefAsyncCallData
Summary: Web Inspector: remove ASSERT from InspectorDebuggerAgent::derefAsyncCallData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-05 14:20 PST by Matt Baker
Modified: 2016-12-07 16:44 PST (History)
11 users (show)

See Also:

Attachments
Patch (1.68 KB, patch)
2016-12-05 14:35 PST, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-12-05 14:20:45 PST 
An async call can be cleared without having been recorded. For example:

- Breakpoints becoming enabled between setTimeout/clearTimeout
- Inspector opening between setTimeout/clearTimeout
- clearTimeout(999) will always go through InspectorInstrumentation
Comment 1 Matt Baker 2016-12-05 14:21:05 PST 
<rdar://problem/29517587>
Comment 2 Matt Baker 2016-12-05 14:35:23 PST 
Created attachment 296189 [details]
Patch
Comment 3 BJ Burg 2016-12-05 14:36:43 PST 
Comment on attachment 296189 [details]
Patch

rs=me
Comment 4 Joseph Pecoraro 2016-12-05 15:00:05 PST 
Comment on attachment 296189 [details]
Patch

We could have a test for this right? Did the clearTimeout(999) on about:blank reproduce this? Either way I'm fine with the test.
Comment 5 WebKit Commit Bot 2016-12-05 17:02:16 PST 
Comment on attachment 296189 [details]
Patch

Clearing flags on attachment: 296189

Committed r209367: <http://trac.webkit.org/changeset/209367>
Comment 6 WebKit Commit Bot 2016-12-05 17:02:20 PST 
All reviewed patches have been landed.  Closing bug.
Comment 7 Joseph Pecoraro 2016-12-06 11:21:12 PST 
(In reply to comment #4)
> Comment on attachment 296189 [details]
> Patch
> 
> We could have a test for this right? Did the clearTimeout(999) on
> about:blank reproduce this? Either way I'm fine with the test.

To answer my own question, yes the clearTimeout(999) did reproduce this.
Comment 8 BJ Burg 2016-12-07 16:44:02 PST 
Still needs a test. It should be pretty basic.