Bug 165397 - Web Inspector: Object.shallowEqual([{}], [{}]) should return true
Summary: Web Inspector: Object.shallowEqual([{}], [{}]) should return true
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-05 11:53 PST by Matt Baker
Modified: 2016-12-05 16:21 PST (History)
7 users (show)

See Also:


Attachments
Patch (5.57 KB, patch)
2016-12-05 12:00 PST, Matt Baker
no flags Details | Formatted Diff | Diff
Patch for landing (5.47 KB, patch)
2016-12-05 15:44 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-12-05 11:53:36 PST
Summary:
Object.shallowEqual([{}], [{}]) should return true.

The problem lies with Array.shallowEqual, which compares items from the two arrays using strict equivalence.
Comment 1 Matt Baker 2016-12-05 12:00:13 PST
Created attachment 296169 [details]
Patch
Comment 2 BJ Burg 2016-12-05 12:09:56 PST
Comment on attachment 296169 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2016-12-05 12:39:06 PST
Comment on attachment 296169 [details]
Patch

Rejecting attachment 296169 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 296169, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
    -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 209338 = 8e65d528f8dbb693757fe621aba0b05bb0aa84f6
r209341 = 088cbbe9411ffd2e08db694ed6bacb80ff8f4b9f
r209342 = 27335f1d5a7e42c0326422174d84f7219547ae6e
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/2628184
Comment 4 Matt Baker 2016-12-05 15:44:19 PST
Created attachment 296205 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-12-05 16:21:44 PST
Comment on attachment 296205 [details]
Patch for landing

Clearing flags on attachment: 296205

Committed r209366: <http://trac.webkit.org/changeset/209366>
Comment 6 WebKit Commit Bot 2016-12-05 16:21:49 PST
All reviewed patches have been landed.  Closing bug.