RESOLVED FIXED Bug 165397
Web Inspector: Object.shallowEqual([{}], [{}]) should return true 
https://bugs.webkit.org/show_bug.cgi?id=165397
Summary Web Inspector: Object.shallowEqual([{}], [{}]) should return true
Matt Baker
Reported 2016-12-05 11:53:36 PST
Summary: Object.shallowEqual([{}], [{}]) should return true. The problem lies with Array.shallowEqual, which compares items from the two arrays using strict equivalence.
Attachments
Patch (5.57 KB, patch)
2016-12-05 12:00 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.47 KB, patch)
2016-12-05 15:44 PST, Matt Baker 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Matt Baker
Comment 1 2016-12-05 12:00:13 PST
Created attachment 296169 [details] Patch
Blaze Burg
Comment 2 2016-12-05 12:09:56 PST
Comment on attachment 296169 [details] Patch r=me
WebKit Commit Bot
Comment 3 2016-12-05 12:39:06 PST
Comment on attachment 296169 [details] Patch Rejecting attachment 296169 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 296169, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 209338 = 8e65d528f8dbb693757fe621aba0b05bb0aa84f6 r209341 = 088cbbe9411ffd2e08db694ed6bacb80ff8f4b9f r209342 = 27335f1d5a7e42c0326422174d84f7219547ae6e Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/2628184
Matt Baker
Comment 4 2016-12-05 15:44:19 PST
Created attachment 296205 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-12-05 16:21:44 PST
Comment on attachment 296205 [details] Patch for landing Clearing flags on attachment: 296205 Committed r209366: <http://trac.webkit.org/changeset/209366>
WebKit Commit Bot
Comment 6 2016-12-05 16:21:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.