Bug 165388 - STP 19 fails to launch on 16B255
Summary: STP 19 fails to launch on 16B255
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ricky Mondello
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-05 11:13 PST by Beth Dakin
Modified: 2016-12-10 09:38 PST (History)
5 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2016-12-05 11:17 PST, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Re-declare the symbols as weak (2.51 KB, patch)
2016-12-05 19:04 PST, Ricky Mondello 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2016-12-05 11:13:42 PST 
STP 19 fails to launch on 16B255

Crash on launch:
Dyld Error Message:
  Symbol not found: _NSTouchBarDidExitCustomization
  Referenced from: /Applications/Safari Technology Preview.app/Contents/MacOS/../Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy
  Expected in: /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit
 in /Applications/Safari Technology Preview.app/Contents/MacOS/../Frameworks/WebKitLegacy.framework/Versions/A/WebKitLegacy

rdar://problem/29514476
Comment 1 Beth Dakin 2016-12-05 11:17:15 PST 
Created attachment 296164 [details]
Patch
Comment 2 Beth Dakin 2016-12-05 11:22:21 PST 
https://trac.webkit.org/changeset/209330
Comment 3 Beth Dakin 2016-12-05 11:26:39 PST 
Follow-up: https://trac.webkit.org/changeset/209332
Comment 4 Tim Horton 2016-12-05 18:58:38 PST 
Reopening for new patch
Comment 5 Ricky Mondello 2016-12-05 19:04:24 PST 
Created attachment 296245 [details]
Re-declare the symbols as weak
Comment 6 WebKit Commit Bot 2016-12-05 19:30:33 PST 
Comment on attachment 296245 [details]
Re-declare the symbols as weak

Clearing flags on attachment: 296245

Committed r209379: <http://trac.webkit.org/changeset/209379>
Comment 7 Brady Eidson 2016-12-05 21:36:04 PST 
I'm on 10.12.1 (non TouchBar machine) with the standard dev tools, and I saw a build failure after this patch related to nullability.

I fixed in https://trac.webkit.org/changeset/209385
Comment 8 Tim Horton 2016-12-10 00:34:51 PST 
My understanding is that this is fixed.
Comment 9 Brady Eidson 2016-12-10 09:38:55 PST 
(In reply to comment #8)
> My understanding is that this is fixed.

Correct - I'm using STP 19 on that OS build with no problems.