Bug 165374 - Add __STDC_FORMAT_MACROS before inttypes.h is included
Summary: Add __STDC_FORMAT_MACROS before inttypes.h is included
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-05 08:30 PST by Konstantin Tokarev
Modified: 2016-12-05 09:48 PST (History)
11 users (show)

See Also:

Attachments
Patch (6.14 KB, patch)
2016-12-05 08:35 PST, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-12-05 08:30:40 PST 
We need formatting macros like PRIu64 to be available in all places where inttypes.h header is used. All these usages get inttypes.h definitions via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting macros are not used anymore since r185129.

This patch fixes multiple build errors with MinGW and reduces number of independent __STDC_FORMAT_MACROS uses in the code base.
Comment 1 Konstantin Tokarev 2016-12-05 08:35:50 PST 
Created attachment 296140 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-05 08:37:39 PST 
Attachment 296140 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Assertions.h:43:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Adler 2016-12-05 09:10:23 PST 
Comment on attachment 296140 [details]
Patch

OK
Comment 4 WebKit Commit Bot 2016-12-05 09:48:00 PST 
Comment on attachment 296140 [details]
Patch

Clearing flags on attachment: 296140

Committed r209322: <http://trac.webkit.org/changeset/209322>
Comment 5 WebKit Commit Bot 2016-12-05 09:48:05 PST 
All reviewed patches have been landed.  Closing bug.