RESOLVED FIXED Bug 165374
Add __STDC_FORMAT_MACROS before inttypes.h is included 
https://bugs.webkit.org/show_bug.cgi?id=165374
Summary Add __STDC_FORMAT_MACROS before inttypes.h is included
Konstantin Tokarev
Reported 2016-12-05 08:30:40 PST
We need formatting macros like PRIu64 to be available in all places where inttypes.h header is used. All these usages get inttypes.h definitions via wtf/Assertions.h header, except SQLiteFileSystem.cpp where formatting macros are not used anymore since r185129. This patch fixes multiple build errors with MinGW and reduces number of independent __STDC_FORMAT_MACROS uses in the code base.
Attachments
Patch (6.14 KB, patch)
2016-12-05 08:35 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2016-12-05 08:35:50 PST
Created attachment 296140 [details] Patch
WebKit Commit Bot
Comment 2 2016-12-05 08:37:39 PST
Attachment 296140 [details] did not pass style-queue: ERROR: Source/WTF/wtf/Assertions.h:43: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2016-12-05 09:10:23 PST
Comment on attachment 296140 [details] Patch OK
WebKit Commit Bot
Comment 4 2016-12-05 09:48:00 PST
Comment on attachment 296140 [details] Patch Clearing flags on attachment: 296140 Committed r209322: <http://trac.webkit.org/changeset/209322>
WebKit Commit Bot
Comment 5 2016-12-05 09:48:05 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.