Bug 165369 - Add support for Wasm ctz and popcnt
Summary: Add support for Wasm ctz and popcnt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-04 13:41 PST by Keith Miller
Modified: 2016-12-04 14:47 PST (History)
4 users (show)

See Also:

Attachments
Patch (16.95 KB, patch)
2016-12-04 13:43 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (16.98 KB, patch)
2016-12-04 13:48 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-04 13:41:48 PST 
Add support for Wasm ctz and popcnt
Comment 1 Keith Miller 2016-12-04 13:43:14 PST 
Created attachment 296102 [details]
Patch
Comment 2 Keith Miller 2016-12-04 13:48:41 PST 
Created attachment 296104 [details]
Patch
Comment 3 WebKit Commit Bot 2016-12-04 13:50:14 PST 
Attachment 296104 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:799:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:810:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2875:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Saam Barati 2016-12-04 14:17:52 PST 
Comment on attachment 296104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296104&action=review

r=me

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2858
> +    static bool supportsBMI1()

I think this should be private.

> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2884
> +    void ctzAfterBsf(RegisterID dst)

This should probably be private too
Comment 5 Keith Miller 2016-12-04 14:22:01 PST 
Comment on attachment 296104 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296104&action=review

>> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2858
>> +    static bool supportsBMI1()
> 
> I think this should be private.

This is protected since the X86_64 macro assembler uses it.

>> Source/JavaScriptCore/assembler/MacroAssemblerX86Common.h:2884
>> +    void ctzAfterBsf(RegisterID dst)
> 
> This should probably be private too

ditto.
Comment 6 WebKit Commit Bot 2016-12-04 14:47:27 PST 
Comment on attachment 296104 [details]
Patch

Clearing flags on attachment: 296104

Committed r209313: <http://trac.webkit.org/changeset/209313>
Comment 7 WebKit Commit Bot 2016-12-04 14:47:31 PST 
All reviewed patches have been landed.  Closing bug.