Bug 165361 - [CSS Parser] Remove line numbers from StyleRule.
Summary: [CSS Parser] Remove line numbers from StyleRule.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-03 12:26 PST by Dave Hyatt
Modified: 2016-12-03 14:56 PST (History)
1 user (show)

See Also:

Attachments
Patch (16.95 KB, patch)
2016-12-03 12:34 PST, Dave Hyatt 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-12-03 12:26:51 PST 
[CSS Parser] Remove line numbers from StyleRule.
Comment 1 Dave Hyatt 2016-12-03 12:34:34 PST 
Created attachment 296058 [details]
Patch
Comment 2 Dave Hyatt 2016-12-03 13:23:20 PST 
Fixed in r209304.
Comment 3 Darin Adler 2016-12-03 14:43:32 PST 
Windows build is failing now:

c:\cygwin\home\buildbot\slave\win-release\build\source\webcore\bindings\js\serializedscriptvalue.cpp(2735): warning C4715: 'WebCore::exceptionForSerializationFailure': not all control paths return a value [C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\Source\WebCore\WebCore.vcxproj]
Comment 4 Darin Adler 2016-12-03 14:44:03 PST 
EFL build also failing:

../../Source/WebCore/bindings/js/SerializedScriptValue.cpp:2735:1: error: control reaches end of non-void function [-Werror=return-type]
Comment 5 Darin Adler 2016-12-03 14:56:15 PST 
Both of those are from Sam's patch, not this one. Sorry!