Bug 165360 - Use ASCIICType more, and improve it a little bit
Summary: Use ASCIICType more, and improve it a little bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-03 11:51 PST by Darin Adler
Modified: 2016-12-06 14:07 PST (History)
3 users (show)

See Also:

Attachments
Patch (59.07 KB, patch)
2016-12-03 12:30 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews100 for mac-yosemite (1.79 MB, application/zip)
2016-12-03 13:52 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.70 MB, application/zip)
2016-12-03 14:00 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (8.14 MB, application/zip)
2016-12-03 14:19 PST, Build Bot 		no flags Details
Patch (59.75 KB, patch)
2016-12-03 15:04 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (58.99 KB, patch)
2016-12-04 13:49 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (58.57 KB, patch)
2016-12-04 14:25 PST, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Patch (58.62 KB, patch)
2016-12-06 08:46 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (58.74 KB, patch)
2016-12-06 08:47 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (7) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-12-03 11:51:44 PST 
Use ASCIICType more, and improve it a little bit
Comment 1 Darin Adler 2016-12-03 12:30:08 PST 
Created attachment 296057 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-03 12:31:57 PST 
Attachment 296057 [details] did not pass style-queue:


ERROR: Source/WebCore/svg/SVGParserUtilities.cpp:65:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 29 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2016-12-03 13:52:53 PST 
Comment on attachment 296057 [details]
Patch

Attachment 296057 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2615276

New failing tests:
js/dom/JSON-stringify.html
Comment 4 Build Bot 2016-12-03 13:52:56 PST 
Created attachment 296064 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 5 Build Bot 2016-12-03 14:00:04 PST 
Comment on attachment 296057 [details]
Patch

Attachment 296057 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2615284

New failing tests:
js/dom/JSON-stringify.html
Comment 6 Build Bot 2016-12-03 14:00:06 PST 
Created attachment 296066 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Build Bot 2016-12-03 14:19:15 PST 
Comment on attachment 296057 [details]
Patch

Attachment 296057 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2615311

New failing tests:
js/dom/JSON-stringify.html
Comment 8 Build Bot 2016-12-03 14:19:18 PST 
Created attachment 296069 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 9 Darin Adler 2016-12-03 15:04:28 PST 
Created attachment 296076 [details]
Patch
Comment 10 Darin Adler 2016-12-04 13:49:15 PST 
Created attachment 296105 [details]
Patch
Comment 11 Darin Adler 2016-12-04 14:25:27 PST 
Created attachment 296107 [details]
Patch
Comment 12 Darin Adler 2016-12-05 07:39:53 PST 
GTK build failure seems unrelated to the patch. But I am not certain.
Comment 13 Sam Weinig 2016-12-05 10:47:42 PST 
Comment on attachment 296107 [details]
Patch

r=me.  No idea what is going on with the Gtk bot. I would try re-uploading the patch to see if it fixes it.
Comment 14 Darin Adler 2016-12-06 08:46:14 PST 
Created attachment 296289 [details]
Patch
Comment 15 Darin Adler 2016-12-06 08:47:38 PST 
Created attachment 296291 [details]
Patch
Comment 16 Darin Adler 2016-12-06 09:18:48 PST 
Committed r209399: <http://trac.webkit.org/changeset/209399>