Bug 165358 - Remove various stray uses of WebCore::Dictionary
Summary: Remove various stray uses of WebCore::Dictionary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-03 09:35 PST by Darin Adler
Modified: 2016-12-06 20:58 PST (History)
2 users (show)

See Also:

Attachments
Patch (45.11 KB, patch)
2016-12-03 09:42 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (48.38 KB, patch)
2016-12-03 17:29 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (47.50 KB, patch)
2016-12-04 13:44 PST, Darin Adler 		sam: review+
Details | Formatted Diff | Diff
Patch (49.82 KB, patch)
2016-12-06 09:15 PST, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2016-12-03 09:35:00 PST 
Remove various stray uses of WebCore::Dictionary
Comment 1 Darin Adler 2016-12-03 09:42:13 PST 
Created attachment 296049 [details]
Patch
Comment 2 Darin Adler 2016-12-03 17:29:51 PST 
Created attachment 296078 [details]
Patch
Comment 3 Darin Adler 2016-12-04 13:44:25 PST 
Created attachment 296103 [details]
Patch
Comment 4 Darin Adler 2016-12-05 07:38:17 PST 
Does anyone understand what these mutate fence failures in Windows linking are? Did I forget to include an inlines header somewhere, or is this a pre-existing build failure not caused by the patch?
Comment 5 Sam Weinig 2016-12-05 10:44:57 PST 
Comment on attachment 296103 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296103&action=review

I think you need to sprinkle some FooInlines.h in the files that fail to link.

> Source/WebCore/Modules/indexeddb/IDBDatabase.h:-30
> -#include "Dictionary.h"

I think this need #include <heap/HeapInlines.h>
Comment 6 Darin Adler 2016-12-06 09:13:03 PST 
I think the inlines situation boils down to this:

- JSDictionary.h includes <runtime/JSCInlines.h>, which includes almost all the JavaScriptCore inlines including HeapInlines.h.

- It's unclear precisely what code IDBDatabase.cpp, for example, compiles that requires HeapInlines.h, but everything worked before because of the JSCInlines.h include from JSDictionary.h.

- I can add includes to fix each compiler error, but since I am not sure in a principled way what file needs to include what header and why, for now, I will put all the includes in the cpp files that fail to compile.
Comment 7 Darin Adler 2016-12-06 09:15:05 PST 
Created attachment 296293 [details]
Patch
Comment 8 Darin Adler 2016-12-06 20:58:51 PST 
Committed r209446: <http://trac.webkit.org/changeset/209446>