Bug 165354 – Improve the behavior of scroll-into-view when the target is inside position:fixed

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Improve the behavior of scroll-into-view when the target is inside position:fixed

[Simon Fraser (smfr)]

Created attachment 296041 [details]
Patch

[alan]

Comment on attachment 296041 [details]
Patch

We ought to find a better way to figure out "inside fixed" state (by changing the existing RenderObject::localToAbsolute(....., bool* wasFixed) logic).

[Simon Fraser (smfr)]

Created attachment 296047 [details]
Patch

[Simon Fraser (smfr)]

(In reply to comment #2)
> Comment on attachment 296041 [details]
> Patch
> 
> We ought to find a better way to figure out "inside fixed" state (by
> changing the existing RenderObject::localToAbsolute(....., bool* wasFixed)
> logic).

We could do another ancestor walk to get it. Or were you thinking of something else?

[Build Bot]

Comment on attachment 296047 [details]
Patch

Attachment 296047 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2613834

New failing tests:
fast/transforms/selection-bounds-in-transformed-view.html

[Build Bot]

Created attachment 296050 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296047 [details]
Patch

Attachment 296047 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2613842

New failing tests:
fast/transforms/selection-bounds-in-transformed-view.html

[Build Bot]

Created attachment 296051 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296047 [details]
Patch

Attachment 296047 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2613840

New failing tests:
fast/transforms/selection-bounds-in-transformed-view.html

[Build Bot]

Created attachment 296052 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Simon Fraser (smfr)]

https://trac.webkit.org/changeset/209299

[Ryan Haddad]

It looks like this change is responsible for the editing/ and fast/ test failures seen here on Sierra WK1:

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r209345%20(1977)/results.html

[Ryan Haddad]

Reverted r209299 for reason:

This change appears to have caused LayoutTest failures on Sierra WK1.

Committed r209348: <http://trac.webkit.org/changeset/209348>

[Ryan Haddad]

(In reply to comment #13)
> Reverted r209299 for reason:
> 
> This change appears to have caused LayoutTest failures on Sierra WK1.
> 
> Committed r209348: <http://trac.webkit.org/changeset/209348>

It looks like the rollout took care of the failures:

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/1981

[Simon Fraser (smfr)]

I can't reproduce those failures locally.

[Simon Fraser (smfr)]

Created attachment 296271 [details]
Patch

[Simon Fraser (smfr)]

Same patch is all green in EWS.

[Simon Fraser (smfr)]

https://trac.webkit.org/r209411