WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
165347
Put names on layers in release builds
https://bugs.webkit.org/show_bug.cgi?id=165347
Summary
Put names on layers in release builds
Simon Fraser (smfr)
Reported
2016-12-02 16:21:40 PST
Put names on layers in release builds
Attachments
Patch
(23.44 KB, patch)
2016-12-02 16:29 PST
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2016-12-02 16:29:47 PST
Created
attachment 296018
[details]
Patch
Tim Horton
Comment 2
2016-12-02 16:34:00 PST
Comment on
attachment 296018
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=296018&action=review
We should probably unify at least the name part of the names between TREE_DEBUGGING and non.
> Source/WebCore/rendering/RenderLayer.cpp:404 > + size_t classNamesToDump = std::min<size_t>(element->classNames().size(), 7); > + for (size_t i = 0; i < classNamesToDump; ++i) {
Add an ellipsis if you have too many?
Simon Fraser (smfr)
Comment 3
2016-12-03 08:27:25 PST
https://trac.webkit.org/changeset/209292
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug