Bug 165339 - Add Wasm floating point nearest and trunc
Summary: Add Wasm floating point nearest and trunc
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords:
Depends on: 165348
Blocks:
  Show dependency tree / graph
 
Reported: 2016-12-02 14:33 PST by Keith Miller
Modified: 2016-12-02 23:31 PST (History)
4 users (show)

See Also:

Attachments
Patch (21.52 KB, patch)
2016-12-02 14:56 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch (20.21 KB, patch)
2016-12-02 19:15 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (20.28 KB, patch)
2016-12-02 19:57 PST, Keith Miller 		no flags Details | Formatted Diff | Diff
Patch for landing (20.21 KB, patch)
2016-12-02 19:58 PST, Keith Miller 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-01 for mac-yosemite (931.73 KB, application/zip)
2016-12-02 21:13 PST, WebKit Commit Bot 		no flags Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2016-12-02 14:33:36 PST 
Add Wasm floating point nearest and trunc
Comment 1 Keith Miller 2016-12-02 14:56:03 PST 
Created attachment 296005 [details]
Patch
Comment 2 Keith Miller 2016-12-02 14:59:44 PST 
Committed r209275: <http://trac.webkit.org/changeset/209275>
Comment 3 WebKit Commit Bot 2016-12-02 16:34:46 PST 
Re-opened since this is blocked by bug 165348
Comment 4 Keith Miller 2016-12-02 19:15:14 PST 
Created attachment 296035 [details]
Patch
Comment 5 Saam Barati 2016-12-02 19:28:58 PST 
Comment on attachment 296035 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2016-12-02 19:40:36 PST 
Comment on attachment 296035 [details]
Patch

Rejecting attachment 296035 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 296035, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/JSTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/2610875
Comment 7 Keith Miller 2016-12-02 19:57:52 PST 
Created attachment 296036 [details]
Patch for landing
Comment 8 Keith Miller 2016-12-02 19:58:38 PST 
Created attachment 296037 [details]
Patch for landing
Comment 9 WebKit Commit Bot 2016-12-02 20:45:41 PST 
The commit-queue encountered the following flaky tests while processing attachment 296037 [details]:

The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2016-12-02 20:46:16 PST 
The commit-queue encountered the following flaky tests while processing attachment 296037 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2016-12-02 21:13:30 PST 
Comment on attachment 296037 [details]
Patch for landing

Rejecting attachment 296037 [details] from commit-queue.

New failing tests:
media/modern-media-controls/media-controller/media-controller-resize.html
Full output: http://webkit-queues.webkit.org/results/2611076
Comment 12 WebKit Commit Bot 2016-12-02 21:13:32 PST 
Created attachment 296040 [details]
Archive of layout-test-results from webkit-cq-01 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-01  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Keith Miller 2016-12-02 23:31:18 PST 
Landed in http://trac.webkit.org/changeset/209295 and I fixed git completely failing in http://trac.webkit.org/changeset/209296.