Bug 165330 - Make IndexedDB.WebProcessKillIDBCleanup even more reliable
Summary: Make IndexedDB.WebProcessKillIDBCleanup even more reliable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-12-02 13:43 PST by Brady Eidson
Modified: 2016-12-02 14:29 PST (History)
2 users (show)

See Also:

Attachments
Patch (2.82 KB, patch)
2016-12-02 13:46 PST, Brady Eidson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-12-02 13:43:03 PST 
Make IndexedDB.WebProcessKillIDBCleanup even more reliable

Just null'ing out the RetainPtr doesn't necessarily destroy the WKWebView, so it doesn't necessarily kill the web content process.

We should explicitly kill it.

Also, by relocating *when* we kill it, we better test that IDB is working as expected.
Comment 1 Brady Eidson 2016-12-02 13:46:06 PST 
Created attachment 295988 [details]
Patch
Comment 2 WebKit Commit Bot 2016-12-02 14:29:40 PST 
Comment on attachment 295988 [details]
Patch

Clearing flags on attachment: 295988

Committed r209269: <http://trac.webkit.org/changeset/209269>
Comment 3 WebKit Commit Bot 2016-12-02 14:29:43 PST 
All reviewed patches have been landed.  Closing bug.