Bug 165321 - [JSC] Stop nulling out the CodeBlock spot inside the call frame inside WebAssembly
Summary: [JSC] Stop nulling out the CodeBlock spot inside the call frame inside WebAss...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-02 11:44 PST by Saam Barati
Modified: 2022-12-21 20:54 PST (History)
12 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-12-02 11:44:34 PST 
A lot of places interpreter non-zero CodeBlock bits to mean a valid CodeBlock. When I do wasm unwinding, I'll need to monitor the code that touches this to make sure it refers to the callee before the CodeBlock to test for a wasm frame. Until then, we'll store zero into that slot just to be safe.
Comment 1 Radar WebKit Bug Importer 2022-12-21 16:52:38 PST 
<rdar://problem/103618930>
Comment 2 Yusuke Suzuki 2022-12-21 16:54:53 PST 
Pull request: https://github.com/WebKit/WebKit/pull/7991
Comment 3 EWS 2022-12-21 20:54:14 PST 
Committed 258233@main (5f73a3c6800b): <https://commits.webkit.org/258233@main>

Reviewed commits have been landed. Closing PR #7991 and removing active labels.