Bug 165317 – Implement the updated port/area-based Scroll Snap Module Level 1 Spec

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Wenson Hsieh]

See http://dev.w3.org/csswg/css-snappoints

[Wenson Hsieh]

<rdar://problem/29490956>

[Wenson Hsieh]

Created attachment 296117 [details]
WIP (ChangeLog not finished yet)

[WebKit Commit Bot]

Attachment 296117 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:691:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
ERROR: Source/WebCore/rendering/style/RenderStyleConstants.h:692:  enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums.  [readability/enum_casing] [4]
Total errors found: 2 in 78 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 296117 [details]
WIP (ChangeLog not finished yet)

Attachment 296117 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2624326

New failing tests:
css3/scroll-snap/scroll-snap-children-with-transforms.html
css3/scroll-snap/scroll-snap-with-scroll-padding.html

[Build Bot]

Created attachment 296121 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296117 [details]
WIP (ChangeLog not finished yet)

Attachment 296117 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2624349

New failing tests:
css3/scroll-snap/scroll-snap-children-with-transforms.html
css3/scroll-snap/scroll-snap-with-scroll-padding.html

[Build Bot]

Created attachment 296122 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296117 [details]
WIP (ChangeLog not finished yet)

Attachment 296117 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2624350

New failing tests:
css3/scroll-snap/scroll-snap-children-with-transforms.html
css3/scroll-snap/scroll-snap-children-with-scroll-snap-margin.html
css3/scroll-snap/scroll-snap-with-scroll-padding.html

[Build Bot]

Created attachment 296123 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 296117 [details]
WIP (ChangeLog not finished yet)

Attachment 296117 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2624363

New failing tests:
css3/scroll-snap/scroll-snap-children-with-transforms.html
css3/scroll-snap/scroll-snap-with-scroll-padding.html
css3/scroll-snap/scroll-snap-children-with-scroll-snap-margin.html
css3/scroll-snap/scroll-snap-positions.html

[Build Bot]

Created attachment 296124 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Wenson Hsieh]

Created attachment 296160 [details]
First pass

[Wenson Hsieh]

Created attachment 296367 [details]
Patch

[Dean Jackson]

Comment on attachment 296367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296367&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1219
> +    return WTFMove(value);

I don't think you need to WTFMove here, assuming value is a Ref<CSSValue>.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1227
> +    return WTFMove(value);

Ditto.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:5374
> -template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ScrollSnapType e)
> +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ScrollSnapStrictness e)
>      : CSSValue(PrimitiveClass)
>  {
>      m_primitiveUnitType = CSS_VALUE_ID;
>      switch (e) {

Use a nicer variable name.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:5407
> +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ScrollSnapAxis e)
> +    : CSSValue(PrimitiveClass)
> +{
> +    m_primitiveUnitType = CSS_VALUE_ID;
> +    switch (e) {

Use a nicer variable name.

> Source/WebCore/css/CSSPrimitiveValueMappings.h:5450
> +template<> inline CSSPrimitiveValue::CSSPrimitiveValue(ScrollSnapAxisAlignType e)
> +    : CSSValue(PrimitiveClass)
> +{
> +    m_primitiveUnitType = CSS_VALUE_ID;
> +    switch (e) {

Ditto.

> Source/WebCore/rendering/style/StyleScrollSnapPoints.cpp:33
> +bool operator==(const ScrollSnapType& a, const ScrollSnapType& b)

Any reason why this isn't inline in the .h?

> Source/WebCore/rendering/style/StyleScrollSnapPoints.cpp:38
> +bool operator==(const ScrollSnapAlign& a, const ScrollSnapAlign& b)

Ditto?

> Source/WebCore/rendering/style/StyleScrollSnapPoints.cpp:54
> +    : scrollPadding(0, 0, 0, 0)

Can you do this in the class definition?

[Wenson Hsieh]

Comment on attachment 296367 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=296367&action=review

>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1219
>> +    return WTFMove(value);
> 
> I don't think you need to WTFMove here, assuming value is a Ref<CSSValue>.

Good point -- fixed.

>> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:1227
>> +    return WTFMove(value);
> 
> Ditto.

Fixed!

>> Source/WebCore/css/CSSPrimitiveValueMappings.h:5374
>>      switch (e) {
> 
> Use a nicer variable name.

Done!

>> Source/WebCore/css/CSSPrimitiveValueMappings.h:5407
>> +    switch (e) {
> 
> Use a nicer variable name.

Done!

>> Source/WebCore/css/CSSPrimitiveValueMappings.h:5450
>> +    switch (e) {
> 
> Ditto.

Done!

>> Source/WebCore/rendering/style/StyleScrollSnapPoints.cpp:33
>> +bool operator==(const ScrollSnapType& a, const ScrollSnapType& b)
> 
> Any reason why this isn't inline in the .h?

No reason! Moved to the .h (and made it inline)

>> Source/WebCore/rendering/style/StyleScrollSnapPoints.cpp:38
>> +bool operator==(const ScrollSnapAlign& a, const ScrollSnapAlign& b)
> 
> Ditto?

Done.

>> Source/WebCore/rendering/style/StyleScrollSnapPoints.cpp:54
>> +    : scrollPadding(0, 0, 0, 0)
> 
> Can you do this in the class definition?

Yes -- moved to the class definition.

[Wenson Hsieh]

Created attachment 297088 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 297088 [details]
Patch for landing

Rejecting attachment 297088 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 297088, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
tTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-overflow.html
patching file LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html
patching file LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-rotated.html
patching file LayoutTests/tiled-drawing/scrolling/scroll-snap/scroll-snap-scrolling-jumps-to-top.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2721159

[Wenson Hsieh]

Created attachment 297090 [details]
Patch for landing

[Wenson Hsieh]

Created attachment 297497 [details]
Patch for landing

[Wenson Hsieh]

Created attachment 297520 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 297520 [details]
Patch for landing

Clearing flags on attachment: 297520

Committed r210024: <http://trac.webkit.org/changeset/210024>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.