Bug 165312 – ERROR: post-layout: dirty renderer(s) - Encountered with LayoutTest media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ryan Haddad]

Encountered with LayoutTest media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html

https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r209234%20(903)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fmodern-media-controls%2Fmedia-controller%2Fmedia-controller-fullscreen-ltr.html

ERROR: post-layout: dirty renderer(s)
/Volumes/Data/slave/sierra-debug/build/Source/WebCore/page/FrameView.cpp(216) : auto WebCore::RenderTreeNeedsLayoutChecker::~RenderTreeNeedsLayoutChecker()::(anonymous class)::operator()(const WebCore::RenderObject &) const

(B)lock/(I)nline/I(N)line-block, (A)bsolute/Fi(X)ed/(R)elative/Stic(K)y, (F)loating, (O)verflow clip, Anon(Y)mous, (G)enerated, has(L)ayer, (C)omposited, (+)Dirty style, (+)Dirty layout
B---YGLC --  RenderView  (0.00, 0.00) (800.00, 600.00) renderer->(0x1189efa00)
B-----L- --    HTML RenderBlock  (0.00, 0.00) (800.00, 111.00) renderer->(0x1185c1af0) node->(0x1185c0ea0)
B------- --      BODY RenderBody  (8.00, 16.00) (784.00, 87.00) renderer->(0x1185c1d20) node->(0x1185c06e8)
B------- --        P RenderBlock  (0.00, 0.00) (784.00, 52.00) renderer->(0x11d3b68c0) node->(0x11d3937b8)
B---YG-- --          RenderBlock  (0.00, 0.00) (784.00, 0.00) renderer->(0x11d3b6d20)
I------- --            SPAN RenderInline renderer->(0x118495240) node->(0x11d3935b0) continuation->(0x11d3b6c08)
B---YG-- --          RenderBlock  (0.00, 0.00) (784.00, 52.00) renderer->(0x11d3b6c08) continuation->(0x118495300)
B------- --            P RenderBlock  (0.00, 0.00) (784.00, 18.00) renderer->(0x11d3b6af0) node->(0x11d393618)
-------- --              SimpleLineLayout (1 lines, 1 runs) (0x11d3879c0)
-------- --                line 0 run(0, 54) (0.00, 0.00) (328.55, 18.00) "Testing ltr is set correctly when entering fullscreen."
I------- --              #text RenderText renderer->(0x11d3766c0) node->(0x118454cd0) length->(54) "Testing ltr is set correctly when entering fullscreen."
B------- --            P RenderBlock  (0.00, 34.00) (784.00, 18.00) renderer->(0x11d3b6118) node->(0x11d393680)
-------- --              RootInlineBox  (0.00, 0.00) (587.29, 18.00) (0x11d3b0dc8) renderer->(0x11d3b6118)
-------- --                InlineTextBox  (0.00, 0.00) (236.25, 18.00) (0x11d376a20) renderer->(0x11d376720) run(0, 38) "On success, you will see a series of ""
-------- --                InlineTextBox  (236.25, 0.00) (37.95, 18.00) (0x11d376a80) renderer->(0x11d376780) run(0, 4) "PASS"
-------- --                InlineTextBox  (274.20, 0.00) (166.37, 18.00) (0x11d376ae0) renderer->(0x11d3767e0) run(0, 25) "" messages, followed by ""
-------- --                InlineTextBox  (440.56, 0.00) (136.20, 18.00) (0x11d376b40) renderer->(0x11d376840) run(0, 13) "TEST COMPLETE"
-------- --                InlineTextBox  (576.76, 0.00) (10.53, 18.00) (0x11d376ba0) renderer->(0x11d3768a0) run(0, 2) ""."
I------- --              #text RenderText renderer->(0x11d376720) node->(0x118454820) length->(38) "On success, you will see a series of ""
I------- --              SPAN RenderInline renderer->(0x1184953c0) node->(0x11d3936e8)
I------- --                #text RenderText renderer->(0x11d376780) node->(0x118454870) length->(4) "PASS"
I------- --              #text RenderText renderer->(0x11d3767e0) node->(0x1184548c0) length->(25) "" messages, followed by ""
I------- --              SPAN RenderInline renderer->(0x118495480) node->(0x11d393750)
I------- --                #text RenderText renderer->(0x11d376840) node->(0x118454910) length->(13) "TEST COMPLETE"
I------- --              #text RenderText renderer->(0x11d3768a0) node->(0x118454960) length->(2) ""."
B---YG-- --          RenderBlock  (0.00, 68.00) (784.00, 0.00) renderer->(0x11d3b6e38)
I------- --            SPAN RenderInline renderer->(0x118495300) node->(0x11d3935b0)
B------- --        DIV RenderBlock  (0.00, 68.00) (784.00, 0.00) renderer->(0x11d3b6348) node->(0x11d393820)
BX--YGLC --        RenderFullScreen  (0.00, 0.00) (800.00, 600.00) renderer->(0x1185c8000)
B-----LC --          VIDEO RenderVideo  (0.00, 0.00) (800.00, 600.00) renderer->(0x11d34d990) node->(0x118bf6b00)
BR----LC --            DIV RenderBlock  (0.00, 0.00) (800.00, 600.00) renderer->(0x11d372460) node->(0x1185c09c0)
BA----LC --              BUTTON RenderButton  (400.00, 300.00) (70.00, 70.00) renderer->(0x1184e6000) node->(0x11857cbd0)
B---YG-- --                RenderBlock  (6.00, 34.50) (58.00, 0.00) renderer->(0x11d372690)
BA----LC --                  DIV RenderBlock  (0.00, 0.00) (70.00, 70.00) renderer->(0x11d372578) node->(0x1185c0c30)
BA----LC --                  IMG RenderImage  (0.00, 0.00) (70.00, 70.00) renderer->(0x11d3a3d68) node->(0x1185ea6e0)
BR----L- -+*           DIV RenderBlock  (0.00, 0.00) (0.00, 0.00) renderer->(0x11d3728c0) node->(0x11d34bc98) layout->[self]
B---YG-- --        RenderBlock  (0.00, 68.00) (784.00, 0.00) renderer->(0x11d3b69d8)
B------- --        DIV RenderBlock  (0.00, 68.00) (784.00, 0.00) renderer->(0x11d3b6460) node->(0x11d393548)
B---YG-- --        RenderBlock  (0.00, 68.00) (784.00, 19.00) renderer->(0x11d372000)
-------- --          RootInlineBox  (0.00, 0.00) (20.00, 18.00) (0x11d3b0f18) renderer->(0x11d372000)
-------- --            InlineBox  (2.00, 2.00) (16.00, 15.00) (0x11d3773a8) renderer->(0x1184e6af8)
N------- --          BUTTON RenderButton  (2.00, 2.00) (16.00, 15.00) renderer->(0x1184e6af8) node->(0x11d3b0c78)
I------- --          #text RenderText renderer->(0x11d376960) node->(0x1184549b0) length->(1) "\n"
I------- --          #text RenderText renderer->(0x11d3769c0) node->(0x11d378050) length->(2) "\n\n"
SHOULD NEVER BE REACHED

[Ryan Haddad]

Seems to have started with https://trac.webkit.org/changeset/209228

[Radar WebKit Bug Importer]

<rdar://problem/29488818>

[Ryan Haddad]

Skipped affected tests in http://trac.webkit.org/projects/webkit/changeset/209349

[Antoine Quint]

Created attachment 296226 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 296226 [details]
Patch

Clearing flags on attachment: 296226

Committed r209375: <http://trac.webkit.org/changeset/209375>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.