Bug 165292 - REGRESSION: LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure
Summary: REGRESSION: LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-01 17:27 PST by Ryan Haddad
Modified: 2017-01-11 17:25 PST (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (6.67 KB, patch)
2017-01-11 16:04 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2016-12-01 17:27:52 PST 
LayoutTest inspector/debugger/csp-exceptions.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r209219%20(9698)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fdebugger%2Fcsp-exceptions.html

--- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/debugger/csp-exceptions-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/debugger/csp-exceptions-actual.txt
@@ -12,4 +12,5 @@
 
 -- Running test case: TriggerCSPExceptionOutsideOfScript
 PASS: CSP Exception caused outside of script evaluation should not pause.
+PASS: CSP Exception caused outside of script evaluation should not pause.
Comment 1 Radar WebKit Bug Importer 2016-12-01 17:28:09 PST 
<rdar://problem/29471892>
Comment 2 Ryan Haddad 2016-12-01 17:29:38 PST 
Seems to be occurring most frequently on mac-wk2 debug.
Comment 3 Ryan Haddad 2016-12-09 16:20:45 PST 
Marked test as flaky on mac-wk2 in http://trac.webkit.org/projects/webkit/changeset/209634
Comment 4 Joseph Pecoraro 2017-01-11 16:01:31 PST 
This looks like a test issue that is easily resolved.
Comment 5 Joseph Pecoraro 2017-01-11 16:04:12 PST 
Created attachment 298624 [details]
[PATCH] Proposed Fix
Comment 6 Joseph Pecoraro 2017-01-11 16:05:04 PST 
I was easily able to reproduce this by running the test individually. And occasionally (1/100) with --iterations=100. After updating the test I consistently see successes.
Comment 7 Geoffrey Garen 2017-01-11 17:01:52 PST 
Comment on attachment 298624 [details]
[PATCH] Proposed Fix

r=me
Comment 8 WebKit Commit Bot 2017-01-11 17:25:48 PST 
Comment on attachment 298624 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 298624

Committed r210611: <http://trac.webkit.org/changeset/210611>
Comment 9 WebKit Commit Bot 2017-01-11 17:25:53 PST 
All reviewed patches have been landed.  Closing bug.