Bug 165284 - [Modern Media Controls] Show and populate the tracks panel
Summary: [Modern Media Controls] Show and populate the tracks panel
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-12-01 15:35 PST by Antoine Quint
Modified: 2016-12-01 18:08 PST (History)
4 users (show)

See Also:

Attachments
Patch (20.11 KB, patch)
2016-12-01 15:38 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (946.33 KB, application/zip)
2016-12-01 16:38 PST, Build Bot 		no flags Details
Patch for landing (21.10 KB, patch)
2016-12-01 16:53 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-12-01 15:35:00 PST 
[Modern Media Controls] Show and populate the tracks panel
Comment 1 Antoine Quint 2016-12-01 15:38:31 PST 
Created attachment 295906 [details]
Patch
Comment 2 Dean Jackson 2016-12-01 16:20:19 PST 
Comment on attachment 295906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295906&action=review

> Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:66
> +video::cue(:future) {

Baller. Didn't know that was possible.

> LayoutTests/platform/ios-simulator/TestExpectations:2748
> +media/modern-media-controls/tracks-support [ Skip ]

I suggest [ Fail ] since the code will actually run to completion, and that way we can be sure that the tracks button will never accidentally show up.
Comment 3 Antoine Quint 2016-12-01 16:31:14 PST 
(In reply to comment #2)
> Comment on attachment 295906 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295906&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:66
> > +video::cue(:future) {
> 
> Baller. Didn't know that was possible.

I didn't write this :)

> > LayoutTests/platform/ios-simulator/TestExpectations:2748
> > +media/modern-media-controls/tracks-support [ Skip ]
> 
> I suggest [ Fail ] since the code will actually run to completion, and that
> way we can be sure that the tracks button will never accidentally show up.

It won't, since there will be no tracks button to click.
Comment 4 Build Bot 2016-12-01 16:38:26 PST 
Comment on attachment 295906 [details]
Patch

Attachment 295906 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2603978

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html
Comment 5 Build Bot 2016-12-01 16:38:28 PST 
Created attachment 295914 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Antoine Quint 2016-12-01 16:53:25 PST 
Created attachment 295915 [details]
Patch for landing
Comment 7 Antoine Quint 2016-12-01 18:08:26 PST 
https://trac.webkit.org/changeset/209227