Bug 165284 – [Modern Media Controls] Show and populate the tracks panel

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

[Modern Media Controls] Show and populate the tracks panel

[Antoine Quint]

Created attachment 295906 [details]
Patch

[Dean Jackson]

Comment on attachment 295906 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295906&action=review

> Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:66
> +video::cue(:future) {

Baller. Didn't know that was possible.

> LayoutTests/platform/ios-simulator/TestExpectations:2748
> +media/modern-media-controls/tracks-support [ Skip ]

I suggest [ Fail ] since the code will actually run to completion, and that way we can be sure that the tracks button will never accidentally show up.

[Antoine Quint]

(In reply to comment #2)
> Comment on attachment 295906 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295906&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/controls/text-tracks.css:66
> > +video::cue(:future) {
> 
> Baller. Didn't know that was possible.

I didn't write this :)

> > LayoutTests/platform/ios-simulator/TestExpectations:2748
> > +media/modern-media-controls/tracks-support [ Skip ]
> 
> I suggest [ Fail ] since the code will actually run to completion, and that
> way we can be sure that the tracks button will never accidentally show up.

It won't, since there will be no tracks button to click.

[Build Bot]

Comment on attachment 295906 [details]
Patch

Attachment 295906 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2603978

New failing tests:
media/modern-media-controls/tracks-support/tracks-support-show-and-populate-panel.html

[Build Bot]

Created attachment 295914 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Antoine Quint]

Created attachment 295915 [details]
Patch for landing

[Antoine Quint]

https://trac.webkit.org/changeset/209227