RESOLVED FIXED 165281
Web Inspector: generated code should use a framework-style import for *ProtocolArrayConversions.h 
https://bugs.webkit.org/show_bug.cgi?id=165281
Summary Web Inspector: generated code should use a framework-style import for *Protoc...
Blaze Burg
Reported 2016-12-01 15:01:24 PST
Better hygiene needed for some annoying reasons.
Attachments
Proposed Fix (14.90 KB, patch)
2016-12-01 15:07 PST, Blaze Burg 		joepeck: review+
bburg: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2016-12-01 15:01:44 PST
<rdar://problem/29427778>
Blaze Burg
Comment 2 2016-12-01 15:07:20 PST
Created attachment 295903 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-12-01 15:08:22 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2016-12-01 15:08:30 PST
Attachment 295903 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:59: [ObjCProtocolTypeConversionsHeaderGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 1 in 15 files If any of these errors are false positives, please file a bug against check-webkit-style.
Joseph Pecoraro
Comment 5 2016-12-01 15:37:47 PST
Comment on attachment 295903 [details] Proposed Fix rs=me, though I wonder why the python style bot didn't like this.
Blaze Burg
Comment 6 2016-12-01 15:48:20 PST
(In reply to comment #5) > Comment on attachment 295903 [details] > Proposed Fix > > rs=me, though I wonder why the python style bot didn't like this. It is not smart enough to think about subclasses and what properties base classes have.
Blaze Burg
Comment 7 2016-12-01 16:52:47 PST
Committed r209222: <http://trac.webkit.org/changeset/209222>
Note You need to log in before you can comment on or make changes to this bug.