Bug 165281 - Web Inspector: generated code should use a framework-style import for *ProtocolArrayConversions.h
Summary: Web Inspector: generated code should use a framework-style import for *Protoc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-01 15:01 PST by BJ Burg
Modified: 2016-12-01 16:52 PST (History)
11 users (show)

See Also:

Attachments
Proposed Fix (14.90 KB, patch)
2016-12-01 15:07 PST, BJ Burg 		joepeck: review+
bburg: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2016-12-01 15:01:24 PST 
Better hygiene needed for some annoying reasons.
Comment 1 BJ Burg 2016-12-01 15:01:44 PST 
<rdar://problem/29427778>
Comment 2 BJ Burg 2016-12-01 15:07:20 PST 
Created attachment 295903 [details]
Proposed Fix
Comment 3 WebKit Commit Bot 2016-12-01 15:08:22 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-12-01 15:08:30 PST 
Attachment 295903 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:59:  [ObjCProtocolTypeConversionsHeaderGenerator.generate_output] Instance of 'ObjCProtocolTypeConversionsHeaderGenerator' has no 'model' member  [pylint/E1101] [5]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Joseph Pecoraro 2016-12-01 15:37:47 PST 
Comment on attachment 295903 [details]
Proposed Fix

rs=me, though I wonder why the python style bot didn't like this.
Comment 6 BJ Burg 2016-12-01 15:48:20 PST 
(In reply to comment #5)
> Comment on attachment 295903 [details]
> Proposed Fix
> 
> rs=me, though I wonder why the python style bot didn't like this.

It is not smart enough to think about subclasses and what properties base classes have.
Comment 7 BJ Burg 2016-12-01 16:52:47 PST 
Committed r209222: <http://trac.webkit.org/changeset/209222>