Summary: Assertion Failures breakpoint should respect global Breakpoints enabled setting. The other "special" breakpoints do, and the "Assertion Failures" breakpoint turns gray when breakpoints are disabled. Steps to Reproduce: 1. Inspect <script>console.assert(false)</script> 2. Debugger tab > Enable 'Assertion Failures' breakpoint 3. Disable all breakpoints (⌘Y) 4. Reload page Expected: => Nothing happens Actual: => Debugger pauses on assertion failure
<rdar://problem/29467098>
Easy fix, going to add a couple tests though: inspector/debugger/break-on-assertion-failure.html inspector/debugger/breakpoints-enabled.html
Doh, my bad. Great find!
(In reply to comment #2) > Easy fix, going to add a couple tests though: > > inspector/debugger/break-on-assertion-failure.html Looks like inspector/debugger/pause-on-assert.html covers the basics.
Created attachment 296024 [details] Patch
Comment on attachment 296024 [details] Patch r=me
Comment on attachment 296024 [details] Patch Clearing flags on attachment: 296024 Committed r209311: <http://trac.webkit.org/changeset/209311>
All reviewed patches have been landed. Closing bug.