Bug 165277 - Web Inspector: Assertion Failures breakpoint should respect global Breakpoints enabled setting
Summary: Web Inspector: Assertion Failures breakpoint should respect global Breakpoint...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-12-01 14:17 PST by Matt Baker
Modified: 2016-12-04 12:23 PST (History)
11 users (show)

See Also:


Attachments
Patch (5.72 KB, patch)
2016-12-02 16:59 PST, Matt Baker
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2016-12-01 14:17:52 PST
Summary:
Assertion Failures breakpoint should respect global Breakpoints enabled setting. The other "special" breakpoints do, and the "Assertion Failures" breakpoint turns gray when breakpoints are disabled.

Steps to Reproduce:
1. Inspect <script>console.assert(false)</script>
2. Debugger tab > Enable 'Assertion Failures' breakpoint
3. Disable all breakpoints (⌘Y)
4. Reload page
Expected:
  => Nothing happens
Actual:
  => Debugger pauses on assertion failure
Comment 1 Radar WebKit Bug Importer 2016-12-01 14:18:05 PST
<rdar://problem/29467098>
Comment 2 Matt Baker 2016-12-01 14:32:24 PST
Easy fix, going to add a couple tests though:

inspector/debugger/break-on-assertion-failure.html
inspector/debugger/breakpoints-enabled.html
Comment 3 Joseph Pecoraro 2016-12-01 14:58:25 PST
Doh, my bad. Great find!
Comment 4 Matt Baker 2016-12-01 18:35:52 PST
(In reply to comment #2)
> Easy fix, going to add a couple tests though:
> 
> inspector/debugger/break-on-assertion-failure.html

Looks like inspector/debugger/pause-on-assert.html covers the basics.
Comment 5 Matt Baker 2016-12-02 16:59:36 PST
Created attachment 296024 [details]
Patch
Comment 6 Mark Lam 2016-12-03 13:18:38 PST
Comment on attachment 296024 [details]
Patch

r=me
Comment 7 WebKit Commit Bot 2016-12-04 12:23:23 PST
Comment on attachment 296024 [details]
Patch

Clearing flags on attachment: 296024

Committed r209311: <http://trac.webkit.org/changeset/209311>
Comment 8 WebKit Commit Bot 2016-12-04 12:23:27 PST
All reviewed patches have been landed.  Closing bug.