Bug 165270 – [iOS][WK2] Tapping an element generates a 'click' event that has 0 as timeStamp

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Tapping an element generates a 'click' event that has 0 as timeStamp.

[Chris Dumez]

<rdar://problem/29224355>

[Chris Dumez]

Created attachment 295887 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 295887 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295887&action=review

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:573
> +    tapWasHandled |= mainframe.eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
> +    tapWasHandled |= mainframe.eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));

Should these be currentMonotonicTime instead? What do we use for other events?

[Chris Dumez]

(In reply to comment #3)
> Comment on attachment 295887 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295887&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:573
> > +    tapWasHandled |= mainframe.eventHandler().handleMousePressEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MousePressed, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
> > +    tapWasHandled |= mainframe.eventHandler().handleMouseReleaseEvent(PlatformMouseEvent(roundedAdjustedPoint, roundedAdjustedPoint, LeftButton, PlatformEvent::MouseReleased, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, syntheticClickType));
> 
> Should these be currentMonotonicTime instead? What do we use for other
> events?

currentTime:
Source/WebCore/dom/Element.cpp:    PlatformMouseEvent platformMouseEvent { frame->eventHandler().lastKnownMousePosition(), frame->eventHandler().lastKnownMouseGlobalPosition(), NoButton, PlatformEvent::NoType, 1, false, false, false, false, WTF::currentTime(), ForceAtClick, NoTap };
Source/WebCore/page/ContextMenuController.cpp:    PlatformMouseEvent mouseEvent(clickPoint, clickPoint, RightButton, PlatformEvent::MousePressed, 1, false, false, false, false, currentTime(), ForceAtClick, NoTap);
Source/WebCore/page/EventHandler.cpp:    PlatformMouseEvent platformMouseEvent(position, globalPosition, RightButton, eventType, 1, false, false, false, false, WTF::currentTime(), ForceAtClick, NoTap);
Source/WebCore/page/EventHandler.cpp:    PlatformMouseEvent fakeMouseMoveEvent(m_lastKnownMousePosition, m_lastKnownMouseGlobalPosition, NoButton, PlatformEvent::MouseMoved, 0, shiftKey, ctrlKey, altKey, metaKey, currentTime(), 0, NoTap);
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:    PlatformMouseEvent mouseEvent(point, point, RightButton, PlatformEvent::MousePressed, 1, false, false, false, false, currentTime(), WebCore::ForceAtClick, WebCore::NoTap);
Source/WebKit2/WebProcess/WebPage/WebPage.cpp:    PlatformMouseEvent event(adjustedClientPosition, adjustedGlobalPosition, LeftButton, PlatformEvent::MouseMoved, 0, false, false, false, false, currentTime(), 0, WebCore::NoTap);

[Chris Dumez]

Comment on attachment 295887 [details]
Patch

Clearing flags on attachment: 295887

Committed r209215: <http://trac.webkit.org/changeset/209215>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Lucas Forschler]

Mass move bugs into the DOM component.