Bug 165257 - Parameter to DOMStringList.contains() should be mandatory
Summary: Parameter to DOMStringList.contains() should be mandatory
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks: 160306
  Show dependency tree / graph
 
Reported: 2016-12-01 09:34 PST by Chris Dumez
Modified: 2016-12-01 13:18 PST (History)
13 users (show)

See Also:

Attachments
Patch (4.36 KB, patch)
2016-12-01 11:10 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.41 MB, application/zip)
2016-12-01 11:53 PST, Build Bot 		no flags Details
Patch (5.93 KB, patch)
2016-12-01 11:56 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-12-01 09:34:54 PST 
Parameter to DOMStringList.contains() should be mandatory.

Firefox and Chrome agree with the specification. WebKit has it as optional and uses the string "undefined" as default value, which is not useful.
Comment 1 Chris Dumez 2016-12-01 11:10:41 PST 
Created attachment 295870 [details]
Patch
Comment 2 Build Bot 2016-12-01 11:53:26 PST 
Comment on attachment 295870 [details]
Patch

Attachment 295870 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2602448

New failing tests:
storage/indexeddb/database-basics-private.html
Comment 3 Build Bot 2016-12-01 11:53:32 PST 
Created attachment 295872 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Chris Dumez 2016-12-01 11:56:46 PST 
Created attachment 295873 [details]
Patch
Comment 5 WebKit Commit Bot 2016-12-01 12:33:27 PST 
Comment on attachment 295873 [details]
Patch

Clearing flags on attachment: 295873

Committed r209193: <http://trac.webkit.org/changeset/209193>
Comment 6 WebKit Commit Bot 2016-12-01 12:33:32 PST 
All reviewed patches have been landed.  Closing bug.