RESOLVED FIXED 165255
Make _WKFullscreenDelegate available to users of the WebKit2 C-API.
https://bugs.webkit.org/show_bug.cgi?id=165255
Summary Make _WKFullscreenDelegate available to users of the WebKit2 C-API.
Jer Noble
Reported 2016-12-01 09:20:26 PST
Make _WKFullscreenDelegate available to users of the WebKit2 C-API.
Attachments
Patch (2.86 KB, patch)
2016-12-01 09:21 PST, Jer Noble
no flags
Patch (2.91 KB, patch)
2016-12-01 12:50 PST, Jer Noble
andersca: review+
Patch for landing (2.96 KB, patch)
2017-01-17 10:20 PST, Jer Noble
jer.noble: commit-queue-
Patch for landing (2.96 KB, patch)
2017-01-17 10:57 PST, Jer Noble
no flags
Patch for landing (2.91 KB, patch)
2017-01-23 17:24 PST, Jer Noble
no flags
Jer Noble
Comment 1 2016-12-01 09:21:43 PST
Jer Noble
Comment 2 2016-12-01 12:50:04 PST
Jer Noble
Comment 3 2016-12-01 13:49:30 PST
The GTK error is in WebCore::jsSubtleCryptoPrototypeFunctionUnwrapKey(), unrelated to this patch.
Anders Carlsson
Comment 4 2016-12-01 14:09:12 PST
Comment on attachment 295881 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295881&action=review > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59 > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page); If possible, please use __weak id here.
Jer Noble
Comment 5 2017-01-06 14:34:34 PST
(In reply to comment #4) > Comment on attachment 295881 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295881&action=review > > > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59 > > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page); > > If possible, please use __weak id here. Doesn't seem to be possible, as __weak only make sense when compiling under ARC, and WKPagePrivateMac.mm doesn't. Adding __weak here just generates a warning.
Jer Noble
Comment 6 2017-01-10 17:38:12 PST
(In reply to comment #5) > (In reply to comment #4) > > Comment on attachment 295881 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=295881&action=review > > > > > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59 > > > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page); > > > > If possible, please use __weak id here. > > Doesn't seem to be possible, as __weak only make sense when compiling under > ARC, and WKPagePrivateMac.mm doesn't. Adding __weak here just generates a > warning. We're already storing the delegate in a WeakObjCPtr, but there doesn't seem to a way to mark the return value of a C function as __weak (or a parameter as __weak) without generating a compiler error. I guess I could do something like: #if !defined WEAK #if __has_feature(objc_arc) #define WEAK _weak #else #define WEAK #endif and then mark up the methods as WK_EXPORT WEAK id <...>; Does that seem right? We don't seem to use __weak in any of the other C-style APIs.
Jer Noble
Comment 7 2017-01-17 10:20:15 PST
Created attachment 299039 [details] Patch for landing
Jer Noble
Comment 8 2017-01-17 10:57:31 PST
Created attachment 299044 [details] Patch for landing
Jer Noble
Comment 9 2017-01-23 17:24:49 PST
Created attachment 299558 [details] Patch for landing
WebKit Commit Bot
Comment 10 2017-01-24 11:57:13 PST
Comment on attachment 299558 [details] Patch for landing Clearing flags on attachment: 299558 Committed r211094: <http://trac.webkit.org/changeset/211094>
Note You need to log in before you can comment on or make changes to this bug.