Bug 165255 – Make _WKFullscreenDelegate available to users of the WebKit2 C-API.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Make _WKFullscreenDelegate available to users of the WebKit2 C-API.

[Jer Noble]

Created attachment 295854 [details]
Patch

[Jer Noble]

Created attachment 295881 [details]
Patch

[Jer Noble]

The GTK error is in WebCore::jsSubtleCryptoPrototypeFunctionUnwrapKey(), unrelated to this patch.

[Anders Carlsson]

Comment on attachment 295881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295881&action=review

> Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59
> +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page);

If possible, please use __weak id here.

[Jer Noble]

(In reply to comment #4)
> Comment on attachment 295881 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295881&action=review
> 
> > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59
> > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page);
> 
> If possible, please use __weak id here.

Doesn't seem to be possible, as __weak only make sense when compiling under ARC, and WKPagePrivateMac.mm doesn't. Adding __weak here just generates a warning.

[Jer Noble]

(In reply to comment #5)
> (In reply to comment #4)
> > Comment on attachment 295881 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=295881&action=review
> > 
> > > Source/WebKit2/UIProcess/API/C/mac/WKPagePrivateMac.h:59
> > > +WK_EXPORT id <_WKFullscreenDelegate> WKPageGetFullscreenDelegate(WKPageRef page);
> > 
> > If possible, please use __weak id here.
> 
> Doesn't seem to be possible, as __weak only make sense when compiling under
> ARC, and WKPagePrivateMac.mm doesn't. Adding __weak here just generates a
> warning.

We're already storing the delegate in a WeakObjCPtr, but there doesn't seem to a way to mark the return value of a C function as __weak (or a parameter as __weak) without generating a compiler error.

I guess I could do something like:

#if !defined WEAK
#if __has_feature(objc_arc)
#define WEAK _weak
#else
#define WEAK
#endif

and then mark up the methods as WK_EXPORT WEAK id <...>; Does that seem right? We don't seem to use __weak in any of the other C-style APIs.

[Jer Noble]

Created attachment 299039 [details]
Patch for landing

[Jer Noble]

Created attachment 299044 [details]
Patch for landing

[Jer Noble]

Created attachment 299558 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 299558 [details]
Patch for landing

Clearing flags on attachment: 299558

Committed r211094: <http://trac.webkit.org/changeset/211094>