Bug 165245 – Web Automation: expose navigator.webdriver if the page is controlled by automation

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Blaze Burg]

Add open source implementation.

[Blaze Burg]

<rdar://problem/29449874>

[Blaze Burg]

Created attachment 295868 [details]
Proposed Fix

Needs to be landed manually with internal changes.

[WebKit Commit Bot]

Attachment 295868 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:43:  The parameter name "navigator" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 295868 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=295868&action=review

I'm sure we could write a test for this!

> Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:37
> +    NavigatorWebDriver(Frame*);

Nit: Could mark this as explicit. I'm not sure how strict we are with this keyword.

[Blaze Burg]

Comment on attachment 295868 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=295868&action=review

>> Source/WebCore/Modules/webdriver/NavigatorWebDriver.h:37
>> +    NavigatorWebDriver(Frame*);
> 
> Nit: Could mark this as explicit. I'm not sure how strict we are with this keyword.

OK

[Blaze Burg]

(In reply to comment #4)
> Comment on attachment 295868 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295868&action=review
> 
> I'm sure we could write a test for this!

We have an integration test for this in Safari's WebDriver test suite, IIRC. I'll file a followup bug.

[Blaze Burg]

Committed r209198: <http://trac.webkit.org/changeset/209198>