Bug 165239 - [Modern Media Controls] Provide a UI object to show a list of tracks
Summary: [Modern Media Controls] Provide a UI object to show a list of tracks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-30 20:34 PST by Antoine Quint
Modified: 2016-12-01 08:26 PST (History)
3 users (show)

See Also:


Attachments
Patch (50.43 KB, patch)
2016-11-30 20:41 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (932.81 KB, application/zip)
2016-11-30 21:41 PST, Build Bot
no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.65 MB, application/zip)
2016-11-30 21:49 PST, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (deleted)
2016-11-30 22:21 PST, Build Bot
no flags Details
Patch (52.27 KB, patch)
2016-12-01 06:06 PST, Antoine Quint
no flags Details | Formatted Diff | Diff
Patch (52.18 KB, patch)
2016-12-01 06:12 PST, Antoine Quint
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-30 20:34:33 PST
[Modern Media Controls] Provide a UI object to show a list of tracks
Comment 1 Antoine Quint 2016-11-30 20:41:46 PST
Created attachment 295814 [details]
Patch
Comment 2 Build Bot 2016-11-30 21:41:12 PST
Comment on attachment 295814 [details]
Patch

Attachment 295814 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2599125

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
Comment 3 Build Bot 2016-11-30 21:41:15 PST
Created attachment 295817 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-11-30 21:49:20 PST
Comment on attachment 295814 [details]
Patch

Attachment 295814 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2599128

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
Comment 5 Build Bot 2016-11-30 21:49:23 PST
Created attachment 295818 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-11-30 22:21:16 PST
Comment on attachment 295814 [details]
Patch

Attachment 295814 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2599176

New failing tests:
media/modern-media-controls/tracks-panel/tracks-panel-hide-click-outside.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-mouse.html
media/modern-media-controls/tracks-panel/tracks-panel-select-track-with-keyboard.html
media/modern-media-controls/tracks-panel/tracks-panel-hide-esc-key.html
Comment 7 Build Bot 2016-11-30 22:21:20 PST
Created attachment 295819 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 8 Antoine Quint 2016-12-01 06:06:27 PST
Created attachment 295843 [details]
Patch
Comment 9 Antoine Quint 2016-12-01 06:12:25 PST
Created attachment 295844 [details]
Patch
Comment 10 Dean Jackson 2016-12-01 08:04:05 PST
Comment on attachment 295844 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295844&action=review

> Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.css:36
> +    font-family: -apple-system;

Why isn't this the font inherited from the shadow root? Surely it is -apple-system everywhere, except for the time labels, which can be explicit on those elements.
Comment 11 Antoine Quint 2016-12-01 08:07:14 PST
(In reply to comment #10)
> Comment on attachment 295844 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295844&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/controls/tracks-panel.css:36
> > +    font-family: -apple-system;
> 
> Why isn't this the font inherited from the shadow root? Surely it is
> -apple-system everywhere, except for the time labels, which can be explicit
> on those elements.

Right, will fix.
Comment 12 Antoine Quint 2016-12-01 08:26:02 PST
https://trac.webkit.org/changeset/209182