When I build WebKit using --minimal option, there is a build break as below, e/WebCore/CMakeFiles/WebCore.dir/css/parser/CSSSelectorParser.cpp.o -c ../../Source/WebCore/css/parser/CSSSelectorParser.cpp ../../Source/WebCore/css/parser/CSSSelectorParser.cpp: In member function ‘std::unique_ptr<WebCore::CSSParserSelector> WebCore::CSSSelectorParser::consumePseudo(WebCore::CSSParserTokenRange&)’: ../../Source/WebCore/css/parser/CSSSelectorParser.cpp:547:48: error: ‘PseudoElementCue’ is not a member of ‘WebCore::CSSSelector’ selector->setPseudoElementType(CSSSelector::PseudoElementCue); It looks we need to use #if ENABLE(VIDEO_TRACK) guard for CSSSelector::PseudoElementCue.
Created attachment 295811 [details] Patch
Comment on attachment 295811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295811&action=review > Source/WebCore/css/parser/CSSSelectorParser.cpp:537 > +#if ENABLE(VIDEO_TRACK) I think the #if should be around the entire if statement, not just around the contents of the body of the if statement.
Created attachment 295816 [details] Patch for landing
(In reply to comment #2) > Comment on attachment 295811 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295811&action=review > > > Source/WebCore/css/parser/CSSSelectorParser.cpp:537 > > +#if ENABLE(VIDEO_TRACK) > > I think the #if should be around the entire if statement, not just around > the contents of the body of the if statement. Done, thanks.
Comment on attachment 295816 [details] Patch for landing Clearing flags on attachment: 295816 Committed r209174: <http://trac.webkit.org/changeset/209174>
All reviewed patches have been landed. Closing bug.