Bug 165238 - Build break when using --minimal
Summary: Build break when using --minimal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-30 19:01 PST by Gyuyoung Kim
Modified: 2016-11-30 21:25 PST (History)
1 user (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2016-11-30 19:02 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch for landing (2.11 KB, patch)
2016-11-30 20:48 PST, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2016-11-30 19:01:10 PST
When I build WebKit using --minimal option, there is a build break as below,

e/WebCore/CMakeFiles/WebCore.dir/css/parser/CSSSelectorParser.cpp.o -c ../../Source/WebCore/css/parser/CSSSelectorParser.cpp
../../Source/WebCore/css/parser/CSSSelectorParser.cpp: In member function ‘std::unique_ptr<WebCore::CSSParserSelector> WebCore::CSSSelectorParser::consumePseudo(WebCore::CSSParserTokenRange&)’:
../../Source/WebCore/css/parser/CSSSelectorParser.cpp:547:48: error: ‘PseudoElementCue’ is not a member of ‘WebCore::CSSSelector’
                 selector->setPseudoElementType(CSSSelector::PseudoElementCue);

It looks we need to use #if ENABLE(VIDEO_TRACK) guard for CSSSelector::PseudoElementCue.
Comment 1 Gyuyoung Kim 2016-11-30 19:02:35 PST
Created attachment 295811 [details]
Patch
Comment 2 Darin Adler 2016-11-30 20:21:37 PST
Comment on attachment 295811 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295811&action=review

> Source/WebCore/css/parser/CSSSelectorParser.cpp:537
> +#if ENABLE(VIDEO_TRACK)

I think the #if should be around the entire if statement, not just around the contents of the body of the if statement.
Comment 3 Gyuyoung Kim 2016-11-30 20:48:08 PST
Created attachment 295816 [details]
Patch for landing
Comment 4 Gyuyoung Kim 2016-11-30 20:48:49 PST
(In reply to comment #2)
> Comment on attachment 295811 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295811&action=review
> 
> > Source/WebCore/css/parser/CSSSelectorParser.cpp:537
> > +#if ENABLE(VIDEO_TRACK)
> 
> I think the #if should be around the entire if statement, not just around
> the contents of the body of the if statement.

Done, thanks.
Comment 5 WebKit Commit Bot 2016-11-30 21:25:44 PST
Comment on attachment 295816 [details]
Patch for landing

Clearing flags on attachment: 295816

Committed r209174: <http://trac.webkit.org/changeset/209174>
Comment 6 WebKit Commit Bot 2016-11-30 21:25:48 PST
All reviewed patches have been landed.  Closing bug.