Bug 165229 - [Modern Media Controls] Add support for right-to-left layouts
Summary: [Modern Media Controls] Add support for right-to-left layouts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-30 16:17 PST by Antoine Quint
Modified: 2016-11-30 19:20 PST (History)
2 users (show)

See Also:

Attachments
Patch (9.82 KB, patch)
2016-11-30 16:18 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (deleted)
2016-11-30 17:38 PST, Build Bot 		no flags Details
Patch for landing (10.77 KB, patch)
2016-11-30 17:38 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-cq-02 for mac-yosemite (1.10 MB, application/zip)
2016-11-30 18:39 PST, WebKit Commit Bot 		no flags Details
Patch for landing (11.71 KB, patch)
2016-11-30 18:43 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-30 16:17:02 PST 
[Modern Media Controls] Add support for right-to-left layouts
Comment 1 Antoine Quint 2016-11-30 16:18:39 PST 
Created attachment 295783 [details]
Patch
Comment 2 Build Bot 2016-11-30 17:38:22 PST 
Comment on attachment 295783 [details]
Patch

Attachment 295783 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2598102

New failing tests:
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html
Comment 3 Build Bot 2016-11-30 17:38:24 PST 
Created attachment 295798 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 4 Antoine Quint 2016-11-30 17:38:50 PST 
Created attachment 295799 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2016-11-30 18:26:27 PST 
The commit-queue encountered the following flaky tests while processing attachment 295799 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2016-11-30 18:27:03 PST 
The commit-queue encountered the following flaky tests while processing attachment 295799 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2016-11-30 18:39:05 PST 
Comment on attachment 295799 [details]
Patch for landing

Rejecting attachment 295799 [details] from commit-queue.

New failing tests:
media/modern-media-controls/media-controller/media-controller-fullscreen-ltr.html
Full output: http://webkit-queues.webkit.org/results/2598467
Comment 8 WebKit Commit Bot 2016-11-30 18:39:07 PST 
Created attachment 295809 [details]
Archive of layout-test-results from webkit-cq-02 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 9 Antoine Quint 2016-11-30 18:43:43 PST 
Created attachment 295810 [details]
Patch for landing
Comment 10 WebKit Commit Bot 2016-11-30 19:20:51 PST 
Comment on attachment 295810 [details]
Patch for landing

Clearing flags on attachment: 295810

Committed r209170: <http://trac.webkit.org/changeset/209170>
Comment 11 WebKit Commit Bot 2016-11-30 19:20:55 PST 
All reviewed patches have been landed.  Closing bug.