Bug 165218 – [WebIDL] Remove custom bindings for File and Blob constructors

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

[WebIDL] Remove custom bindings for File and Blob constructors

[Sam Weinig]

Created attachment 295763 [details]
Patch

[WebKit Commit Bot]

Attachment 295763 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/Blob.h:103:  The parameter name "propertyBag" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 295768 [details]
Patch

[WebKit Commit Bot]

Attachment 295768 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/Blob.h:103:  The parameter name "propertyBag" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Created attachment 295769 [details]
Patch

[Sam Weinig]

Created attachment 295778 [details]
Patch

[Build Bot]

Comment on attachment 295778 [details]
Patch

Attachment 295778 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2597808

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/request-headers.html
fast/files/blob-constructor.html
fast/files/file-constructor.html
imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker.html
http/tests/fetch/fetch-as-blob-worker.html
http/tests/fetch/fetch-as-blob.html

[Build Bot]

Created attachment 295785 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 295778 [details]
Patch

Attachment 295778 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2597839

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/request-headers.html
fast/files/blob-constructor.html
fast/files/file-constructor.html
imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker.html
http/tests/fetch/fetch-as-blob-worker.html
http/tests/fetch/fetch-as-blob.html

[Build Bot]

Created attachment 295786 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295778 [details]
Patch

Attachment 295778 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2597926

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/request-headers.html
fast/files/blob-constructor.html
fast/files/file-constructor.html
imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker.html
http/tests/fetch/fetch-as-blob-worker.html
http/tests/fetch/fetch-as-blob.html

[Build Bot]

Created attachment 295791 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Sam Weinig]

Created attachment 295797 [details]
Patch

[Darin Adler]

Comment on attachment 295797 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295797&action=review

> Source/WebCore/fileapi/Blob.h:37
>  #include <wtf/RefCounted.h>

No need for RefCounted.h once we include URL.h.

> Source/WebCore/fileapi/Blob.h:39
>  #include <wtf/text/WTFString.h>

No need for WTFString.h once we include URL.h.

> Source/WebCore/fileapi/Blob.h:44
> +};

No need for a semicolon here.

> Source/WebCore/fileapi/BlobBuilder.cpp:73
> +    CString utf8Text = UTF8Encoding().encode(text, EntitiesForUnencodables);

Don’t we have a better way to convert to UTF-8? Annoying to have to use a CString.

> Source/WebCore/fileapi/BlobBuilder.h:51
> +    void append(RefPtr<JSC::ArrayBuffer>&&);
>      void append(RefPtr<JSC::ArrayBufferView>&&);
> +    void append(RefPtr<Blob>&&);

Why RefPtr&& instead of const RefPtr& for these? Separately, why can’t these just take raw pointers instead?

> Source/WebCore/fileapi/File.idl:35
>      Exposed=(Window),
>      JSGenerateToNativeObject,
>      JSGenerateToJSObject,
>      ExportMacro=WEBCORE_EXPORT,
> -    CustomConstructor(sequence<any> fileBits, DOMString fileName, optional FilePropertyBag options),
> +    Constructor(sequence<BlobPart> fileBits, USVString fileName, optional FilePropertyBag options),

Normally we sort extended attributes alphabetically.

[Sam Weinig]

Committed r209184: <http://trac.webkit.org/changeset/209184>