Bug 165213 - [CSS Parser] Turn on the new CSS parser
Summary: [CSS Parser] Turn on the new CSS parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46591
  Show dependency tree / graph
 
Reported: 2016-11-30 12:43 PST by Dave Hyatt
Modified: 2022-09-02 18:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.20 KB, patch)
2016-11-30 12:44 PST, Dave Hyatt 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.37 MB, application/zip)
2016-11-30 13:19 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-yosemite-wk2 (1.05 MB, application/zip)
2016-11-30 13:27 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (2.13 MB, application/zip)
2016-11-30 13:36 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (7.27 MB, application/zip)
2016-11-30 13:38 PST, Build Bot 		no flags Details
Patch (1.23 KB, patch)
2016-12-02 08:47 PST, Dave Hyatt 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews102 for mac-yosemite (1.42 MB, application/zip)
2016-12-02 09:49 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.60 MB, application/zip)
2016-12-02 09:58 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews114 for mac-yosemite (2.26 MB, application/zip)
2016-12-02 10:02 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted)
2016-12-02 10:07 PST, Build Bot 		no flags Details
Patch (1.27 KB, patch)
2016-12-02 15:09 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews101 for mac-yosemite (1.01 MB, application/zip)
2016-12-02 16:10 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews115 for mac-yosemite (1.86 MB, application/zip)
2016-12-02 16:14 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.18 MB, application/zip)
2016-12-02 16:20 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews123 for ios-simulator-wk2 (deleted)
2016-12-02 16:30 PST, Build Bot 		no flags Details
Patch (1.24 KB, patch)
2016-12-03 13:45 PST, Dave Hyatt 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (957.47 KB, application/zip)
2016-12-03 14:44 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (955.74 KB, application/zip)
2016-12-03 14:49 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews116 for mac-yosemite (1.93 MB, application/zip)
2016-12-03 14:56 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (9.87 MB, application/zip)
2016-12-03 15:00 PST, Build Bot 		no flags Details
Patch (1.86 KB, patch)
2016-12-06 00:16 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (9.41 MB, application/zip)
2016-12-06 01:31 PST, Build Bot 		no flags Details
Patch (1.59 KB, patch)
2016-12-06 08:08 PST, Dave Hyatt 		no flags Details | Formatted Diff | Diff
Patch (2.56 KB, patch)
2016-12-06 08:10 PST, Dave Hyatt 		zalan: review+
Details | Formatted Diff | Diff
Show Obsolete (23) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2016-11-30 12:43:24 PST 
[CSS Parser] Turn on the new CSS parser
Comment 1 Dave Hyatt 2016-11-30 12:44:17 PST 
Created attachment 295743 [details]
Patch
Comment 2 Build Bot 2016-11-30 13:19:14 PST 
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2596802

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-11-30 13:19:16 PST 
Created attachment 295748 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-11-30 13:27:12 PST 
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2596808

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-11-30 13:27:15 PST 
Created attachment 295750 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-11-30 13:36:38 PST 
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2596809

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-11-30 13:36:41 PST 
Created attachment 295754 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-11-30 13:38:45 PST 
Comment on attachment 295743 [details]
Patch

Attachment 295743 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2596815

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-11-30 13:38:48 PST 
Created attachment 295755 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Dave Hyatt 2016-12-02 08:47:40 PST 
Created attachment 295947 [details]
Patch
Comment 11 Build Bot 2016-12-02 09:49:51 PST 
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2607854

New failing tests:
fast/media/mq-color-gamut.html
fast/selectors/pseudo-element-inside-any.html
fast/backgrounds/repeat/parsing-background-repeat.html
cssom/cssvalue-comparison.html
fast/css/remove-shorthand.html
fast/gradients/generated-gradients.html
fast/text/crash-complex-text-surrogate.html
fast/css/css-set-selector-text.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/dom/HTMLElement/dynamic-editability-change.html
fast/css/unknown-pseudo-element-matching.html
animations/animation-add-events-in-handler.html
fast/selectors/not-active-hover-quirks.html
inspector/console/css-source-locations.html
transitions/svg-transitions.html
fast/css/css-selector-text.html
fast/css/large-value-csstext.html
fast/selectors/active-quirks.html
fast/css/media-rule-no-whitespace.html
Comment 12 Build Bot 2016-12-02 09:49:54 PST 
Created attachment 295954 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 13 Build Bot 2016-12-02 09:58:01 PST 
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2607877

New failing tests:
fast/selectors/pseudo-element-inside-any.html
fast/css/css-set-selector-text.html
cssom/cssvalue-comparison.html
fast/css/remove-shorthand.html
fast/gradients/generated-gradients.html
fast/dom/HTMLElement/dynamic-editability-change.html
fast/text/crash-complex-text-surrogate.html
fast/backgrounds/repeat/parsing-background-repeat.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/media/mq-color-gamut.html
fast/css/unknown-pseudo-element-matching.html
animations/animation-add-events-in-handler.html
transitions/svg-transitions.html
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
fast/css/media-rule-no-whitespace.html
fast/selectors/active-quirks.html
fast/css/large-value-csstext.html
Comment 14 Build Bot 2016-12-02 09:58:04 PST 
Created attachment 295956 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 15 Build Bot 2016-12-02 10:02:32 PST 
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2607852

New failing tests:
fast/media/mq-color-gamut.html
fast/css/css-set-selector-text.html
cssom/cssvalue-comparison.html
fast/css/remove-shorthand.html
fast/gradients/generated-gradients.html
fast/text/crash-complex-text-surrogate.html
fast/backgrounds/repeat/parsing-background-repeat.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/dom/HTMLElement/dynamic-editability-change.html
fast/css/unknown-pseudo-element-matching.html
animations/animation-add-events-in-handler.html
transitions/svg-transitions.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
fast/css/large-value-csstext.html
fast/css/media-rule-no-whitespace.html
Comment 16 Build Bot 2016-12-02 10:02:35 PST 
Created attachment 295957 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 17 Build Bot 2016-12-02 10:07:52 PST 
Comment on attachment 295947 [details]
Patch

Attachment 295947 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2607887

New failing tests:
fast/media/mq-color-gamut.html
fast/text/letterpress-different.html
fast/css/css-set-selector-text.html
fast/text/trak-optimizeLegibility.html
fast/css/remove-shorthand.html
fast/selectors/pseudo-element-inside-any.html
fast/gradients/generated-gradients.html
fast/text/crash-complex-text-surrogate.html
fast/backgrounds/repeat/parsing-background-repeat.html
fast/css/transform-origin-parsing.html
fast/selectors/querySelector-pseudo-element-inside-functional-pseudo-class-any.html
fast/css/transform-inline-style-remove.html
fast/shadow-dom/slotted-pseudo-element-css-text.html
fast/dom/HTMLElement/dynamic-editability-change.html
animations/animation-add-events-in-handler.html
transitions/svg-transitions.html
fast/css/media-rule-no-whitespace.html
fast/css/large-value-csstext.html
Comment 18 Build Bot 2016-12-02 10:07:56 PST 
Created attachment 295958 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 19 Dave Hyatt 2016-12-02 15:09:34 PST 
Created attachment 296008 [details]
Patch
Comment 20 WebKit Commit Bot 2016-12-02 15:10:59 PST 
Attachment 296008 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParser.cpp:254:  Should have a space between // and comment  [whitespace/comments] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 21 Build Bot 2016-12-02 16:10:41 PST 
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2609898

New failing tests:
cssom/cssvalue-comparison.html
animations/animation-add-events-in-handler.html
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
fast/selectors/hover-quirks.html
Comment 22 Build Bot 2016-12-02 16:10:45 PST 
Created attachment 296015 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 23 Build Bot 2016-12-02 16:14:03 PST 
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2609893

New failing tests:
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
cssom/cssvalue-comparison.html
animations/animation-add-events-in-handler.html
Comment 24 Build Bot 2016-12-02 16:14:08 PST 
Created attachment 296016 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 25 Build Bot 2016-12-02 16:20:28 PST 
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2609912

New failing tests:
inspector/console/css-source-locations.html
fast/selectors/not-active-hover-quirks.html
fast/css/css-selector-text.html
cssom/cssvalue-comparison.html
animations/animation-add-events-in-handler.html
Comment 26 Build Bot 2016-12-02 16:20:31 PST 
Created attachment 296017 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 27 Build Bot 2016-12-02 16:30:30 PST 
Comment on attachment 296008 [details]
Patch

Attachment 296008 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2609914

New failing tests:
animations/animation-add-events-in-handler.html
fast/shadow-dom/slotted-pseudo-element-css-text.html
Comment 28 Build Bot 2016-12-02 16:30:35 PST 
Created attachment 296019 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 29 Dave Hyatt 2016-12-03 13:45:16 PST 
Created attachment 296063 [details]
Patch
Comment 30 Build Bot 2016-12-03 14:44:43 PST 
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2615745

New failing tests:
fast/selectors/not-active-hover-quirks.html
fast/selectors/hover-quirks.html
Comment 31 Build Bot 2016-12-03 14:44:47 PST 
Created attachment 296071 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 32 Build Bot 2016-12-03 14:49:09 PST 
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2615747

New failing tests:
fast/selectors/not-active-hover-quirks.html
fast/selectors/hover-quirks.html
Comment 33 Build Bot 2016-12-03 14:49:13 PST 
Created attachment 296073 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 34 Build Bot 2016-12-03 14:56:40 PST 
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2615749

New failing tests:
fast/selectors/not-active-hover-quirks.html
inspector/heap/tracking.html
Comment 35 Build Bot 2016-12-03 14:56:43 PST 
Created attachment 296074 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 36 Build Bot 2016-12-03 15:00:22 PST 
Comment on attachment 296063 [details]
Patch

Attachment 296063 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2615754

New failing tests:
fast/shadow-dom/slotted-pseudo-element-css-text.html
Comment 37 Build Bot 2016-12-03 15:00:26 PST 
Created attachment 296075 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 38 Dave Hyatt 2016-12-06 00:16:07 PST 
Created attachment 296280 [details]
Patch
Comment 39 WebKit Commit Bot 2016-12-06 00:18:54 PST 
Attachment 296280 [details] did not pass style-queue:


ERROR: Source/WebCore/css/parser/CSSParser.cpp:254:  Should have a space between // and comment  [whitespace/comments] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 40 Build Bot 2016-12-06 01:31:47 PST 
Comment on attachment 296280 [details]
Patch

Attachment 296280 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2632562

New failing tests:
fast/shadow-dom/slotted-pseudo-element-css-text.html
Comment 41 Build Bot 2016-12-06 01:31:52 PST 
Created attachment 296284 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 42 Dave Hyatt 2016-12-06 08:08:21 PST 
Created attachment 296287 [details]
Patch
Comment 43 Dave Hyatt 2016-12-06 08:10:20 PST 
Created attachment 296288 [details]
Patch
Comment 44 Dave Hyatt 2016-12-06 08:55:16 PST 
Turned on in r209396!