patch coming. <rdar://problem/28654967>
Created attachment 295734 [details] proposed patch.
Comment on attachment 295734 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295734&action=review r=me > LayoutTests/js/dom/proxy-is-not-allowed-in-global-prototype-chain.html:12 > + if (e == "TypeError: Proxy is not allowed in the global prototype chain.") > + log("PASS: onerror saw " + e); > + else > + log("FAIL: onerror saw unexpected exception " + e); > +} In tests like this, I think it's best juts to log the error message, without judging whether it's a pass or a fail. Our test infrastructure will flag it for review if the result ever changes -- but we don't know in advance that any change to error message text is definitely bad.
Comment on attachment 295734 [details] proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=295734&action=review >> LayoutTests/js/dom/proxy-is-not-allowed-in-global-prototype-chain.html:12 >> +} > > In tests like this, I think it's best juts to log the error message, without judging whether it's a pass or a fail. Our test infrastructure will flag it for review if the result ever changes -- but we don't know in advance that any change to error message text is definitely bad. OK, I'll change it accordingly.
Thanks for the review. Landed in r209149: <http://trac.webkit.org/r209149>.