Bug 165201 - REGRESSION (209086): IDB tests crash under GuardMalloc
Summary: REGRESSION (209086): IDB tests crash under GuardMalloc
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-30 09:17 PST by Brady Eidson
Modified: 2016-11-30 11:34 PST (History)
3 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2016-11-30 09:32 PST, Brady Eidson 		cdumez: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews112 for mac-yosemite (2.33 MB, application/zip)
2016-11-30 11:34 PST, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2016-11-30 09:17:44 PST 
REGRESSION (209086): IDB tests crash under GuardMalloc

https://trac.webkit.org/changeset/209086

At least some of the TransactionOperations in the IDBTransaction m_transactionOperationsInProgressQueue queue are not protected as they should be. (Queue of raw ptrs)

Exploring.
Comment 1 Brady Eidson 2016-11-30 09:31:08 PST 
Found it, easy fix.
Comment 2 Brady Eidson 2016-11-30 09:32:51 PST 
Created attachment 295724 [details]
Patch
Comment 3 Chris Dumez 2016-11-30 09:35:46 PST 
Comment on attachment 295724 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295724&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        No new tests (Covered by literally every IDB test when run under GuardMallo).

typo: GuardMallo
Comment 4 Build Bot 2016-11-30 11:34:50 PST 
Comment on attachment 295724 [details]
Patch

Attachment 295724 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2596306

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-11-30 11:34:53 PST 
Created attachment 295736 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5