Bug 165183 - [Modern Media Controls] Controls are not visible when returning from picture-in-picture playback
Summary: [Modern Media Controls] Controls are not visible when returning from picture-...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-29 17:55 PST by Antoine Quint
Modified: 2016-11-30 14:46 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.09 KB, patch)
2016-11-29 17:58 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch for landing (4.15 KB, patch)
2016-11-30 14:15 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-29 17:55:02 PST 
[Modern Media Controls] Controls are not visible when returning from picture-in-picture playback
Comment 1 Antoine Quint 2016-11-29 17:58:01 PST 
Created attachment 295687 [details]
Patch
Comment 2 Dean Jackson 2016-11-29 18:01:45 PST 
Comment on attachment 295687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295687&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:122
> +        const host = this.host;
> +        const media = this.media;

No need for these variables.
Comment 3 Dean Jackson 2016-11-29 18:01:56 PST 
Comment on attachment 295687 [details]
Patch

Where is the test?
Comment 4 Dean Jackson 2016-11-29 18:03:02 PST 
Sam will be very angry that there isn't a test.
Comment 5 Antoine Quint 2016-11-29 18:06:18 PST 
(In reply to comment #2)
> Comment on attachment 295687 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295687&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:122
> > +        const host = this.host;
> > +        const media = this.media;
> 
> No need for these variables.

Nice, didn't know fat-arrow functions correctly scoped `this`.
Comment 6 Antoine Quint 2016-11-29 18:06:50 PST 
(In reply to comment #4)
> Sam will be very angry that there isn't a test.

I'm open to suggestions as to how to test this. A pixel test?
Comment 7 Antoine Quint 2016-11-30 14:15:06 PST 
Created attachment 295766 [details]
Patch for landing
Comment 8 Radar WebKit Bug Importer 2016-11-30 14:15:23 PST 
<rdar://problem/29446209>
Comment 9 WebKit Commit Bot 2016-11-30 14:45:58 PST 
Comment on attachment 295766 [details]
Patch for landing

Clearing flags on attachment: 295766

Committed r209156: <http://trac.webkit.org/changeset/209156>
Comment 10 WebKit Commit Bot 2016-11-30 14:46:02 PST 
All reviewed patches have been landed.  Closing bug.