Bug 165183 – [Modern Media Controls] Controls are not visible when returning from picture-in-picture playback

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

[Modern Media Controls] Controls are not visible when returning from picture-in-picture playback

[Antoine Quint]

Created attachment 295687 [details]
Patch

[Dean Jackson]

Comment on attachment 295687 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295687&action=review

> Source/WebCore/Modules/modern-media-controls/media/media-controller.js:122
> +        const host = this.host;
> +        const media = this.media;

No need for these variables.

[Dean Jackson]

Comment on attachment 295687 [details]
Patch

Where is the test?

[Dean Jackson]

Sam will be very angry that there isn't a test.

[Antoine Quint]

(In reply to comment #2)
> Comment on attachment 295687 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295687&action=review
> 
> > Source/WebCore/Modules/modern-media-controls/media/media-controller.js:122
> > +        const host = this.host;
> > +        const media = this.media;
> 
> No need for these variables.

Nice, didn't know fat-arrow functions correctly scoped `this`.

[Antoine Quint]

(In reply to comment #4)
> Sam will be very angry that there isn't a test.

I'm open to suggestions as to how to test this. A pixel test?

[Antoine Quint]

Created attachment 295766 [details]
Patch for landing

[Radar WebKit Bug Importer]

<rdar://problem/29446209>

[WebKit Commit Bot]

Comment on attachment 295766 [details]
Patch for landing

Clearing flags on attachment: 295766

Committed r209156: <http://trac.webkit.org/changeset/209156>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.