Bug 165180 - [Modern Media Controls] Show an invalid placard when we fail to load a media file
Summary: [Modern Media Controls] Show an invalid placard when we fail to load a media ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-29 17:47 PST by Antoine Quint
Modified: 2016-11-29 19:06 PST (History)
3 users (show)

See Also:

Attachments
Patch (31.57 KB, patch)
2016-11-29 17:49 PST, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2016-11-29 17:47:18 PST 
[Modern Media Controls] Show an invalid placard when we fail to load a media file
Comment 1 Antoine Quint 2016-11-29 17:49:27 PST 
Created attachment 295684 [details]
Patch
Comment 2 Dean Jackson 2016-11-29 17:59:42 PST 
Comment on attachment 295684 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295684&action=review

> Source/WebCore/ChangeLog:8
> +        We now show a placard with an "invalid" icon when we fail to load the media file.

Is this a placard? Why isn't it just a inactive start button with a different image?
Comment 3 Antoine Quint 2016-11-29 18:01:37 PST 
(In reply to comment #2)
> Comment on attachment 295684 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295684&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        We now show a placard with an "invalid" icon when we fail to load the media file.
> 
> Is this a placard? Why isn't it just a inactive start button with a
> different image?

Because it gets a black background as well and it conditions the display of the controls bar. It's really designed as a placard so it is natural to implement it as such.
Comment 4 WebKit Commit Bot 2016-11-29 19:06:15 PST 
Comment on attachment 295684 [details]
Patch

Clearing flags on attachment: 295684

Committed r209111: <http://trac.webkit.org/changeset/209111>
Comment 5 WebKit Commit Bot 2016-11-29 19:06:18 PST 
All reviewed patches have been landed.  Closing bug.