Bug 165172 - Web Inspector: Add icons for temporarily disabled Code Coverage and Type profilers
Summary: Web Inspector: Add icons for temporarily disabled Code Coverage and Type prof...
Status: RESOLVED DUPLICATE of bug 163345
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks: 163345
  Show dependency tree / graph
 
Reported: 2016-11-29 16:15 PST by Nikita Vasilyev
Modified: 2016-12-01 16:23 PST (History)
8 users (show)

See Also:

Attachments
[Image] Dotted outline (29.51 KB, image/png)
2016-11-30 16:12 PST, Nikita Vasilyev 		no flags Details
Patch (2.28 KB, patch)
2016-12-01 14:28 PST, Nikita Vasilyev 		joepeck: review-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2016-11-29 16:15:25 PST 
Some ideas:
1. Change outline of [T] and [C] icons to dashed.
2. Change the color from blue to orange.
Comment 1 Nikita Vasilyev 2016-11-30 16:12:40 PST 
Created attachment 295781 [details]
[Image] Dotted outline

Dotted outline (stroke-dasharray: 1 1).

The C and T letters are unchanged. I experimented with making them dashed but it didn't work well for the T letter — it's too small to keep it legible.
Comment 2 Radar WebKit Bug Importer 2016-11-30 16:13:54 PST 
<rdar://problem/29448741>
Comment 3 Nikita Vasilyev 2016-12-01 14:28:02 PST 
Created attachment 295897 [details]
Patch
Comment 4 Joseph Pecoraro 2016-12-01 16:06:09 PST 
Comment on attachment 295897 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295897&action=review

Neat!

We should add these icons at the same time that we make use of them. There is no reason for a separate commit for unused images. Including them when we use them will make it clear what we are doing / should do for other ports that don't use our images (for example, Images/gtk).

> Source/WebInspectorUI/UserInterface/Images/NavigationItemTypesTemporaryDisabled.svg:2
> +<!-- Copyright © 2014 Apple Inc. All rights reserved. -->

Should this be 2016?
Comment 5 Nikita Vasilyev 2016-12-01 16:23:48 PST 
(In reply to comment #4)
> Comment on attachment 295897 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295897&action=review
> 
> Neat!
> 
> We should add these icons at the same time that we make use of them. There
> is no reason for a separate commit for unused images. Including them when we
> use them will make it clear what we are doing / should do for other ports
> that don't use our images (for example, Images/gtk).

Okay!

> 
> > Source/WebInspectorUI/UserInterface/Images/NavigationItemTypesTemporaryDisabled.svg:2
> > +<!-- Copyright © 2014 Apple Inc. All rights reserved. -->
> 
> Should this be 2016?

It should!

*** This bug has been marked as a duplicate of bug 163345 ***