RESOLVED DUPLICATE of bug 163345 165172
Web Inspector: Add icons for temporarily disabled Code Coverage and Type profilers 
https://bugs.webkit.org/show_bug.cgi?id=165172
Summary Web Inspector: Add icons for temporarily disabled Code Coverage and Type prof...
Nikita Vasilyev
Reported 2016-11-29 16:15:25 PST
Some ideas: 1. Change outline of [T] and [C] icons to dashed. 2. Change the color from blue to orange.
Attachments
[Image] Dotted outline (29.51 KB, image/png)
2016-11-30 16:12 PST, Nikita Vasilyev 		no flags
Details
Patch (2.28 KB, patch)
2016-12-01 14:28 PST, Nikita Vasilyev 		joepeck: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2016-11-30 16:12:40 PST
Created attachment 295781 [details] [Image] Dotted outline Dotted outline (stroke-dasharray: 1 1). The C and T letters are unchanged. I experimented with making them dashed but it didn't work well for the T letter — it's too small to keep it legible.
Radar WebKit Bug Importer
Comment 2 2016-11-30 16:13:54 PST
<rdar://problem/29448741>
Nikita Vasilyev
Comment 3 2016-12-01 14:28:02 PST
Created attachment 295897 [details] Patch
Joseph Pecoraro
Comment 4 2016-12-01 16:06:09 PST
Comment on attachment 295897 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=295897&action=review Neat! We should add these icons at the same time that we make use of them. There is no reason for a separate commit for unused images. Including them when we use them will make it clear what we are doing / should do for other ports that don't use our images (for example, Images/gtk). > Source/WebInspectorUI/UserInterface/Images/NavigationItemTypesTemporaryDisabled.svg:2 > +<!-- Copyright © 2014 Apple Inc. All rights reserved. --> Should this be 2016?
Nikita Vasilyev
Comment 5 2016-12-01 16:23:48 PST
(In reply to comment #4) > Comment on attachment 295897 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=295897&action=review > > Neat! > > We should add these icons at the same time that we make use of them. There > is no reason for a separate commit for unused images. Including them when we > use them will make it clear what we are doing / should do for other ports > that don't use our images (for example, Images/gtk). Okay! > > > Source/WebInspectorUI/UserInterface/Images/NavigationItemTypesTemporaryDisabled.svg:2 > > +<!-- Copyright © 2014 Apple Inc. All rights reserved. --> > > Should this be 2016? It should! *** This bug has been marked as a duplicate of bug 163345 ***
Note You need to log in before you can comment on or make changes to this bug.