Bug 165171 – Add support for globalThis

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Keith Miller]

Add support for global

[Keith Miller]

Created attachment 295668 [details]
Patch

[Build Bot]

Comment on attachment 295668 [details]
Patch

Attachment 295668 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2591732

New failing tests:
js/dom/getOwnPropertyDescriptor.html

[Build Bot]

Created attachment 295677 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295668 [details]
Patch

Attachment 295668 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2591771

New failing tests:
js/dom/getOwnPropertyDescriptor.html

[Build Bot]

Created attachment 295680 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 295668 [details]
Patch

Attachment 295668 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2591813

New failing tests:
js/dom/getOwnPropertyDescriptor.html

[Build Bot]

Created attachment 295682 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 295668 [details]
Patch

Attachment 295668 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2593202

New failing tests:
js/dom/getOwnPropertyDescriptor.html

[Build Bot]

Created attachment 295703 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Jordan Harband]

Any update here? :-D

[Keith Miller]

(In reply to comment #10)
> Any update here? :-D

Whoops, totally forgot about this patch. I'll fix the test and cq again.

[Keith Miller]

Created attachment 297576 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 297576 [details]
Patch for landing

Clearing flags on attachment: 297576

Committed r210052: <http://trac.webkit.org/changeset/210052>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/29782794>

[Sergey Rubanov]

Any info on next WebKit Nightly release date? Last release was 2 weeks ago

[Lucas Forschler]

The WebKit nightly builder was having an issue. I have kicked off a new build, and will watch its progress.

[Lucas Forschler]

r210247.dmg">https://builds-nightly.webkit.org/files/trunk/mac/WebKit-SVN-r210247.dmg

[WebKit Commit Bot]

Re-opened since this is blocked by bug 166915

[Sergey Rubanov]

This was (mistakenly?) landed to Safari TP 21

[Jordan Harband]

Not mistakenly - it predates the web compat issues that popped up.

It should be reverted, but any web compat issues learned about via TP 21 would be very helpful.

[Ryosuke Niwa]

We had to rollout this feature it broke Polymer tests.

[karl]

Firefox has implemented it too in Nightly. 
https://bugzilla.mozilla.org/show_bug.cgi?id=1317422

It broke a couple of things.
Flickr: https://bugzilla.mozilla.org/show_bug.cgi?id=1325907
Deezer: https://bugzilla.mozilla.org/show_bug.cgi?id=1326032
Jira:   https://bugzilla.mozilla.org/show_bug.cgi?id=1328218

[Jordan Harband]

The identifier is now named `globalThis`; Chrome is already shipping it. Can this get another shot? :-)

[Keith Miller]

(In reply to Jordan Harband from comment #24)
> The identifier is now named `globalThis`; Chrome is already shipping it. Can
> this get another shot? :-)

Sure, I forgot about this. Will upload a patch shortly.

[Keith Miller]

Created attachment 357848 [details]
Patch

[Keith Miller]

Created attachment 357849 [details]
Patch

[Saam Barati]

Comment on attachment 357849 [details]
Patch

Can you add a layout test asserting this is === window?

[Mark Lam]

Comment on attachment 357849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=357849&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        This patch adds spport for the globalThis property on the global

spport => support

[Keith Miller]

(In reply to Saam Barati from comment #28)
> Comment on attachment 357849 [details]
> Patch
> 
> Can you add a layout test asserting this is === window?

Sounds good!

[Keith Miller]

Created attachment 357852 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 357852 [details]
Patch for landing

Clearing flags on attachment: 357852

Committed r239464: <https://trac.webkit.org/changeset/239464>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Saam Barati]

Comment on attachment 357852 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=357852&action=review

> LayoutTests/js/globalThis-is-window.html:13
> +// testRunner.waitUntilDone();

oops

[Saam Barati]

Comment on attachment 357852 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=357852&action=review

> Source/JavaScriptCore/runtime/JSGlobalObject.cpp:305
> +  globalThis            JSGlobalObject::m_globalThis                 DontEnum|CellProperty

We should add tests where we
- delete this property
- ensure its not enumerable
if such tests aren't in test262 already

[Truitt Savell]

It appears that this revision https://trac.webkit.org/changeset/239464/webkit 
did cause the 32-bit JSC test failure.

failure:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/3331

I ran a clean build of 32-bit JSC on 239463 and it passed all testing:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/3391

I then ran a clean build of 239464 and it failed:
https://build.webkit.org/builders/Apple%20High%20Sierra%2032-bit%20JSC%20%28BuildAndTest%29/builds/3435

[Jordan Harband]

Any idea why adding a global identifier would cause a test failure?

It might be notable that `jsc` has no identifier for the global object prior to this feature (although it's still accessible via `Function('return this')()`). Could that be causing issues?

[Ross Kirsling]

*** Bug 186785 has been marked as a duplicate of this bug. ***