Bug 165168 - [Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource
Summary: [Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-11-29 15:50 PST by Andy Estes
Modified: 2016-11-30 12:34 PST (History)
8 users (show)

See Also:

Attachments
Patch (5.11 KB, patch)
2016-11-29 15:55 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (5.14 KB, patch)
2016-11-29 15:56 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (5.19 KB, patch)
2016-11-30 09:17 PST, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2016-11-29 15:50:05 PST 
[Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource
Comment 1 Andy Estes 2016-11-29 15:51:15 PST 
<rdar://problem/29003618>
Comment 2 Andy Estes 2016-11-29 15:55:27 PST 
Created attachment 295657 [details]
Patch
Comment 3 Andy Estes 2016-11-29 15:56:02 PST 
Created attachment 295658 [details]
Patch
Comment 4 Simon Fraser (smfr) 2016-11-29 16:58:33 PST 
Comment on attachment 295658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295658&action=review

> Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:78
> +    // FIXME: Remove the -respondsToSelector: check once -setSourceAppBundleID: is in an SDK.

Is there a radar tracking that? Better to cite the radar.

> Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:83
> +// FIXME: Confine this to the !USE(APPLE_INTERNAL_SDK) section once this is defined in an SDK.

Also cite the radar.
Comment 5 Andy Estes 2016-11-30 09:09:07 PST 
(In reply to comment #4)
> Comment on attachment 295658 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295658&action=review
> 
> > Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:78
> > +    // FIXME: Remove the -respondsToSelector: check once -setSourceAppBundleID: is in an SDK.
> 
> Is there a radar tracking that? Better to cite the radar.
> 
> > Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:83
> > +// FIXME: Confine this to the !USE(APPLE_INTERNAL_SDK) section once this is defined in an SDK.
> 
> Also cite the radar.

There is a Radar, and I'll cite it. Thanks for the review!
Comment 6 Andy Estes 2016-11-30 09:17:13 PST 
Created attachment 295722 [details]
Patch
Comment 7 WebKit Commit Bot 2016-11-30 12:07:15 PST 
The commit-queue encountered the following flaky tests while processing attachment 295722 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2016-11-30 12:07:50 PST 
The commit-queue encountered the following flaky tests while processing attachment 295722 [details]:

transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2016-11-30 12:34:39 PST 
Comment on attachment 295722 [details]
Patch

Clearing flags on attachment: 295722

Committed r209147: <http://trac.webkit.org/changeset/209147>
Comment 10 WebKit Commit Bot 2016-11-30 12:34:44 PST 
All reviewed patches have been landed.  Closing bug.