Bug 165168 – [Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Cocoa] Pass the embedding app's bundle ID to new instances of NEFilterSource

[Andy Estes]

<rdar://problem/29003618>

[Andy Estes]

Created attachment 295657 [details]
Patch

[Andy Estes]

Created attachment 295658 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 295658 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295658&action=review

> Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:78
> +    // FIXME: Remove the -respondsToSelector: check once -setSourceAppBundleID: is in an SDK.

Is there a radar tracking that? Better to cite the radar.

> Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:83
> +// FIXME: Confine this to the !USE(APPLE_INTERNAL_SDK) section once this is defined in an SDK.

Also cite the radar.

[Andy Estes]

(In reply to comment #4)
> Comment on attachment 295658 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295658&action=review
> 
> > Source/WebCore/platform/cocoa/NetworkExtensionContentFilter.mm:78
> > +    // FIXME: Remove the -respondsToSelector: check once -setSourceAppBundleID: is in an SDK.
> 
> Is there a radar tracking that? Better to cite the radar.
> 
> > Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h:83
> > +// FIXME: Confine this to the !USE(APPLE_INTERNAL_SDK) section once this is defined in an SDK.
> 
> Also cite the radar.

There is a Radar, and I'll cite it. Thanks for the review!

[Andy Estes]

Created attachment 295722 [details]
Patch

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 295722 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 295722 [details]:

transitions/default-timing-function.html bug 138901 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 295722 [details]
Patch

Clearing flags on attachment: 295722

Committed r209147: <http://trac.webkit.org/changeset/209147>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.