Bug 165158 - Remove WebPage::SetPageSuppressed
Summary: Remove WebPage::SetPageSuppressed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
: 163873 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-11-29 14:28 PST by Gavin Barraclough
Modified: 2016-11-29 17:00 PST (History)
1 user (show)

See Also:


Attachments
Fix (8.09 KB, patch)
2016-11-29 14:34 PST, Gavin Barraclough
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-11-29 14:28:45 PST
This was scaffolding. We've now refactored to the point that the information driving throttling originates from the UI process (so UI and web processes can have a consistent view of what should throttle), but we don't need a separate message to handle this - necessary state to determine is provided in ActivityState.
Comment 1 Gavin Barraclough 2016-11-29 14:29:57 PST
*** Bug 163873 has been marked as a duplicate of this bug. ***
Comment 2 Gavin Barraclough 2016-11-29 14:34:30 PST
Created attachment 295643 [details]
Fix
Comment 3 Tim Horton 2016-11-29 14:42:21 PST
Comment on attachment 295643 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=295643&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2552
> +    if (changed)

Can we just early return and avoid all of this work if nothing has changed?
Comment 4 Gavin Barraclough 2016-11-29 14:57:01 PST
(In reply to comment #3)
> Comment on attachment 295643 [details]
> Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=295643&action=review
> 
> > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2552
> > +    if (changed)
> 
> Can we just early return and avoid all of this work if nothing has changed?

I think this may require a larger change; will consider as a separate patch.
Comment 5 Gavin Barraclough 2016-11-29 17:00:37 PST
Committed revision 209102.