Bug 165156 - [WebIDL] Add support for more missing / exotic IDLTypes
Summary: [WebIDL] Add support for more missing / exotic IDLTypes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-29 13:46 PST by Sam Weinig
Modified: 2016-11-30 14:11 PST (History)
2 users (show)

See Also:

Attachments
Patch (97.98 KB, patch)
2016-11-29 14:12 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (1.52 MB, application/zip)
2016-11-29 14:52 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (473.64 KB, application/zip)
2016-11-29 15:01 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (394.44 KB, application/zip)
2016-11-29 15:05 PST, Build Bot 		no flags Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (deleted)
2016-11-29 15:32 PST, Build Bot 		no flags Details
Patch (98.45 KB, patch)
2016-11-30 11:16 PST, Sam Weinig 		achristensen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-11-29 13:46:07 PST 
[WebIDL] Add support for more missing / exotic IDLTypes
Comment 1 Sam Weinig 2016-11-29 14:12:16 PST 
Created attachment 295637 [details]
Patch
Comment 2 Build Bot 2016-11-29 14:52:23 PST 
Comment on attachment 295637 [details]
Patch

Attachment 295637 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2590920

Number of test failures exceeded the failure limit.
Comment 3 Build Bot 2016-11-29 14:52:26 PST 
Created attachment 295647 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-11-29 15:01:20 PST 
Comment on attachment 295637 [details]
Patch

Attachment 295637 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2590987

Number of test failures exceeded the failure limit.
Comment 5 Build Bot 2016-11-29 15:01:23 PST 
Created attachment 295649 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-11-29 15:05:41 PST 
Comment on attachment 295637 [details]
Patch

Attachment 295637 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2590985

Number of test failures exceeded the failure limit.
Comment 7 Build Bot 2016-11-29 15:05:44 PST 
Created attachment 295650 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-11-29 15:32:28 PST 
Comment on attachment 295637 [details]
Patch

Attachment 295637 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2591037

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2016-11-29 15:32:34 PST 
Created attachment 295655 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Sam Weinig 2016-11-30 11:16:19 PST 
Created attachment 295735 [details]
Patch
Comment 11 Alex Christensen 2016-11-30 13:05:37 PST 
Comment on attachment 295735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295735&action=review

> Source/WebCore/bindings/js/JSDOMConvert.h:1419
> +    static RefPtr<T> convert(JSC::ExecState& state, JSC::JSValue value)

can this be Ref<T>?
Comment 12 Sam Weinig 2016-11-30 14:11:08 PST 
Committed r209153: <http://trac.webkit.org/changeset/209153>