Bug 165149 – REGRESSION (r208930): [Sierra WK1] LayoutTest fast/forms/validation-message-appearance.html failing

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

LayoutTest fast/forms/validation-message-appearance.html failing

https://build.webkit.org/results/Apple%20Sierra%20Release%20WK1%20(Tests)/r209045%20(1766)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fforms%2Fvalidation-message-appearance.html

--- /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/fast/forms/validation-message-appearance-expected.txt
+++ /Volumes/Data/slave/sierra-release-tests-wk1/build/layout-test-results/fast/forms/validation-message-appearance-actual.txt
@@ -4,18 +4,18 @@
   RenderBlock {HTML} at (0,0) size 800x39
     RenderBody {BODY} at (8,8) size 784x23
       RenderBlock {FORM} at (0,0) size 784x23
-        RenderTextControl {INPUT} at (2,2) size 137x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
-          RenderFlexibleBox {DIV} at (3,3) size 131x13
-            RenderBlock {DIV} at (0,0) size 131x13
-        RenderText {#text} at (140,2) size 5x18
-          text run at (140,2) width 5: " "
-        RenderButton {INPUT} at (146,3) size 54x18 [bgcolor=#C0C0C0]
-          RenderBlock (anonymous) at (8,2) size 38x13
-            RenderText at (0,0) size 38x13
-              text run at (0,0) width 38: "Submit"
+        RenderTextControl {INPUT} at (2,2) size 146x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
+          RenderFlexibleBox {DIV} at (3,3) size 140x13
+            RenderBlock {DIV} at (0,0) size 140x13
+        RenderText {#text} at (149,2) size 5x18
+          text run at (149,2) width 5: " "
+        RenderButton {INPUT} at (155,3) size 54x18 [bgcolor=#C0C0C0]
+          RenderBlock (anonymous) at (8,2) size 37x13
+            RenderText at (0,0) size 37x13
+              text run at (0,0) width 37: "Submit"
         RenderText {#text} at (0,0) size 0x0
-layer at (13,13) size 130x13
-  RenderBlock {DIV} at (0,0) size 131x13
+layer at (13,13) size 140x13
+  RenderBlock {DIV} at (0,0) size 140x13
 layer at (10,29) size 220x100
   RenderBlock (positioned) zI: 2147483647 {DIV} at (10,29) size 220x100
 layer at (10,29) size 220x16 scrollHeight 25
@@ -25,15 +25,15 @@
     RenderBlock {DIV} at (10,10) size 0x64
     RenderBlock {DIV} at (10,10) size 200x64
       RenderBlock {DIV} at (0,0) size 200x16
-        RenderText {#text} at (0,0) size 105x16
-          text run at (0,0) width 105: "Fill out this field"
+        RenderText {#text} at (0,0) size 104x16
+          text run at (0,0) width 104: "Fill out this field"
       RenderBlock {DIV} at (0,16) size 200x48
-        RenderText {#text} at (0,0) size 147x16
-          text run at (0,0) width 147: "Needs at least 8 letters."
-        RenderBR {BR} at (146,0) size 1x16
-        RenderText {#text} at (0,16) size 195x32
-          text run at (0,16) width 195: "Should not be identical with the"
-          text run at (0,32) width 112: "current password."
+        RenderText {#text} at (0,0) size 145x16
+          text run at (0,0) width 145: "Needs at least 8 letters."
+        RenderBR {BR} at (144,0) size 1x16
+        RenderText {#text} at (0,16) size 192x32
+          text run at (0,16) width 192: "Should not be identical with the"
+          text run at (0,32) width 110: "current password."
 layer at (42,29) size 18x18 backgroundClip at (10,29) size 220x16 clip at (10,29) size 220x16
   RenderBlock (relative positioned) zI: 2147483645 {DIV} at (0,0) size 18x18 [bgcolor=#F8ECEC] [border: (2px solid #440000) none (2px solid #440000)]
 caret: position 0 of child 0 {DIV} of child 0 {DIV} of child 0 {DIV} of {#document-fragment} of child 1 {INPUT} of child 0 {FORM} of body

[Ryan Haddad]

This is limited to Sierra WK1 and seems to have started with the changes in https://trac.webkit.org/changeset/208930

[Chris Dumez]

Needs a new baseline. Will look into it after lunch if no one else has.

[Ryan Haddad]

(In reply to comment #2)
> Needs a new baseline. Will look into it after lunch if no one else has.

I can rebaseline it.

[Ryan Haddad]

(In reply to comment #3)
> (In reply to comment #2)
> > Needs a new baseline. Will look into it after lunch if no one else has.
> 
> I can rebaseline it.

http://trac.webkit.org/projects/webkit/changeset/209081

[Chris Dumez]

(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Needs a new baseline. Will look into it after lunch if no one else has.
> > 
> > I can rebaseline it.
> 
> http://trac.webkit.org/projects/webkit/changeset/209081

Thank you Ryan.