Bug 165148 – Can't download move.simple.com direct deposit transition PDF: Non user-triggered activations of anchors that have a download attribute are ignored

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Can't download move.simple.com direct deposit transition PDF:
 [Warning] Non user-triggered activations of anchors that have a download attribute are ignored. (app-7d2adbd6a086ab6b1d3f.js, line 65)

We are stricter than other browsers as they allow synthetic clicks and it causes compatibility issues.

[Chris Dumez]

<rdar://problem/29421771>

[Chris Dumez]

Created attachment 295625 [details]
Patch

[Daniel Bates]

Comment on attachment 295625 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=295625&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        We were ignoring non user-triggered activations of anchors that have a
> +        download attribute which is stricter than Chrome and Firefox and breaks

Our current behavior conforms to the HTML spec. Have you filed an issue to change the spec? (I haven't checked yet). Unless the spec will be changed before this patch is landed I suggest that we explicitly mention that we are making this change against the spec (citing the date of the spec) for compatibility to match the behavior in the aforementioned other browsers and provide a URL to the WHATWG issue that we filed (or an existing one) to change the spec to align to the behavior we want to adopt.

[Chris Dumez]

Filed <https://github.com/whatwg/html/issues/2116> against the spec.

[Chris Dumez]

(In reply to comment #4)
> Filed <https://github.com/whatwg/html/issues/2116> against the spec.

I am uncertain about the benefit of adding a comment especially because it will likely be outdated soon.

[Chris Dumez]

Committed r209091: <http://trac.webkit.org/changeset/209091>