Bug 165133 - intersection-observer-entry-interface.html test fails on the bots
Summary: intersection-observer-entry-interface.html test fails on the bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari 9
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: https://build.webkit.org/results/Appl...
Keywords:
Depends on:
Blocks:
 
Reported: 2016-11-28 22:46 PST by Simon Fraser (smfr)
Modified: 2016-11-29 09:16 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.78 KB, patch)
2016-11-28 23:10 PST, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-11-28 22:46:55 PST 
intersection-observer-entry-interface.html is failing on the bots, but does not when the test is run locally on its own.
Comment 1 Simon Fraser (smfr) 2016-11-28 22:48:47 PST 
The bug is that TestController::ensureViewSupportsOptionsForTest() early returns if it thinks the current view supports the new test options. However, the code fails to check for a difference in the enableIntersectionObserver option.

In general, this code is confused about options that must be set before view creation, and those that can be set as normal preferences.
Comment 2 Simon Fraser (smfr) 2016-11-28 23:10:56 PST 
Created attachment 295585 [details]
Patch
Comment 3 WebKit Commit Bot 2016-11-29 09:16:27 PST 
Comment on attachment 295585 [details]
Patch

Clearing flags on attachment: 295585

Committed r209073: <http://trac.webkit.org/changeset/209073>
Comment 4 WebKit Commit Bot 2016-11-29 09:16:31 PST 
All reviewed patches have been landed.  Closing bug.